Skip to content

What comes before v1.0? #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adityasaky opened this issue Mar 2, 2021 · 12 comments
Closed

What comes before v1.0? #21

adityasaky opened this issue Mar 2, 2021 · 12 comments

Comments

@adityasaky
Copy link
Member

With these requirements addressed in the current draft of the signing-spec, it's likely time to discuss what needs to be addressed before we're ready to tag v1.0. Achieving stability in the spec would enable us to work on the adoption in-spec in ITE-5 / TAP-TBD, and in-code via work on signing-spec implementations.

@adityasaky
Copy link
Member Author

@adityasaky
Copy link
Member Author

@trishankatdatadog
Copy link
Collaborator

Do we have working prototypes somewhere, especially one to support Google's use case, and another to support our Canonical JSON? That would be the only thing that would really convince me, not endless specifications.

@MarkLodato
Copy link
Collaborator

I suggest creating a GitHub milestone for this. (If you add me as an editor in the project, I'd be happy to set that up for you.)

I filed #28 for the reference implementation.

@adityasaky
Copy link
Member Author

I've created the milestone and added #28 to it.

@dlorenc
Copy link

dlorenc commented Jun 4, 2021

Do we have working prototypes somewhere, especially one to support Google's use case, and another to support our Canonical JSON? That would be the only thing that would really convince me, not endless specifications.

I don't know if this is a "reference" implementation, but we have "an" implementation here: https://github.com/in-toto/in-toto-golang/blob/master/pkg/ssl/sign.go

@MarkLodato
Copy link
Collaborator

I propose that the following are the only blockers:

Once we have done these three, we tag it as 1.0. Any objections?

@TomHennen
Copy link
Collaborator

How much do were care about #27? There's already an implementation that uses the already defined PAE.

I'm fine either way, I just want to make sure this is actually a good use of time.

@MarkLodato
Copy link
Collaborator

IMO it's valuable since it significantly simplifies the implementation and is an easy change to make.

@TomHennen
Copy link
Collaborator

SGTM

@laurentsimon
Copy link

I chatted offline with @MarkLodato on the possibility to use a simpler encoding for the envelope part too: that would prevent recipients from using a full-blown json parser on untrusted input. But it's yet more work to make this change and may not best use of time at this stage.

@MarkLodato
Copy link
Collaborator

It's 1.0 now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants