Skip to content

Commit 33d03fc

Browse files
briemcnallyBrandon Sneed
and
Brandon Sneed
authored
[STRATCONN-434] Update Headers for iOS 14 work (#85)
* Run pod install * Update podfile to use cocoapods 1.10.0.rc.1 * Update import headers * remove output file from build phases * Show env vars in build log * Update build for storyboard and update simulator * Tried deintegrate/install and pin to 7.0.1 to reset to a legit state Co-authored-by: Brandon Sneed <[email protected]>
1 parent 3b7fbdc commit 33d03fc

File tree

8 files changed

+90
-66
lines changed

8 files changed

+90
-66
lines changed

Example/Podfile.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ PODS:
55
- OCHamcrest (7.1.2)
66
- OCMockito (5.1.3):
77
- OCHamcrest (~> 7.0)
8-
- Segment-Amplitude (3.2.0):
9-
- Amplitude
8+
- Segment-Amplitude (3.2.1):
9+
- Amplitude (~> 7.0.1)
1010
- Analytics
1111
- Specta (1.0.7)
1212

@@ -35,9 +35,9 @@ SPEC CHECKSUMS:
3535
Expecta: 3b6bd90a64b9a1dcb0b70aa0e10a7f8f631667d5
3636
OCHamcrest: b284c9592c28c1e4025a8542e67ea41a635d0d73
3737
OCMockito: 677cbb4a18fd492b5a4fb10144dada4de5ddb877
38-
Segment-Amplitude: 300e2888691b75b8364389b2c242f6b953932945
38+
Segment-Amplitude: 42876f7adc8544948e876770e8d839b462f3c51b
3939
Specta: 3e1bd89c3517421982dc4d1c992503e48bd5fe66
4040

4141
PODFILE CHECKSUM: a7bf6ef16f54033a66dc8c09524260667af4e881
4242

43-
COCOAPODS: 1.10.0.rc.1
43+
COCOAPODS: 1.9.3

Example/Segment-Amplitude.xcodeproj/project.pbxproj

+61-52
Large diffs are not rendered by default.
+9-7
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1-
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
2-
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="7706" systemVersion="14D136" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" initialViewController="whP-gf-Uak">
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="15705" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES" initialViewController="whP-gf-Uak">
3+
<device id="retina4_7" orientation="portrait" appearance="light"/>
34
<dependencies>
4-
<deployment identifier="iOS"/>
5-
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="7703"/>
5+
<deployment version="4352" identifier="iOS"/>
6+
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="15706"/>
7+
<capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
68
</dependencies>
79
<scenes>
810
<!--View Controller-->
@@ -14,14 +16,14 @@
1416
<viewControllerLayoutGuide type="bottom" id="Mvr-aV-6Um"/>
1517
</layoutGuides>
1618
<view key="view" contentMode="scaleToFill" id="TpU-gO-2f1">
17-
<rect key="frame" x="0.0" y="0.0" width="600" height="600"/>
19+
<rect key="frame" x="0.0" y="0.0" width="375" height="667"/>
1820
<autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
19-
<color key="backgroundColor" white="1" alpha="1" colorSpace="calibratedWhite"/>
21+
<color key="backgroundColor" red="1" green="1" blue="1" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
2022
</view>
2123
</viewController>
2224
<placeholder placeholderIdentifier="IBFirstResponder" id="tc2-Qw-aMS" userLabel="First Responder" sceneMemberID="firstResponder"/>
2325
</objects>
24-
<point key="canvasLocation" x="305" y="433"/>
26+
<point key="canvasLocation" x="-14" y="75"/>
2527
</scene>
2628
</scenes>
2729
</document>

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
SDK ?= "iphonesimulator"
2-
DESTINATION ?= "platform=iOS Simulator,name=iPhone 8"
2+
DESTINATION ?= "platform=iOS Simulator,name=iPhone 11"
33
PROJECT := Segment-Amplitude
44
XC_ARGS := -scheme $(PROJECT)_Example -workspace Example/$(PROJECT).xcworkspace -sdk $(SDK) -destination $(DESTINATION) ONLY_ACTIVE_ARCH=NO
55

Pod/Classes/SEGAmplitudeIntegration.h

+5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
#import <Foundation/Foundation.h>
2+
3+
#if defined(__has_include) && __has_include(<Analytics/Analytics.h>)
24
#import <Analytics/Analytics.h>
5+
#else
6+
#import <Segment/Analytics.h>
7+
#endif
38

49
#if defined(__has_include) && __has_include(<Amplitude_iOS/Amplitude.h>)
510
#import <Amplitude_iOS/Amplitude.h>

Pod/Classes/SEGAmplitudeIntegration.m

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
#import "SEGAmplitudeIntegration.h"
2+
#if defined(__has_include) && __has_include(<Analytics/Analytics.h>)
23
#import <Analytics/Analytics.h>
4+
#else
5+
#import <Segment/Analytics.h>
6+
#endif
37

48

59
@implementation SEGAmplitudeIntegration

Pod/Classes/SEGAmplitudeIntegrationFactory.h

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
#import <Foundation/Foundation.h>
2-
#import <Analytics/Analytics.h>
32

3+
#if defined(__has_include) && __has_include(<Analytics/Analytics.h>)
4+
#import <Analytics/Analytics.h>
5+
#else
6+
#import <Segment/Analytics.h>
7+
#endif
48
#import "SEGAmplitudeIntegration.h"
59

610

Segment-Amplitude.podspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,5 @@ Pod::Spec.new do |s|
2222
s.source_files = 'Pod/Classes/**/*'
2323

2424
s.dependency 'Analytics'
25-
s.dependency 'Amplitude'
25+
s.dependency 'Amplitude', '~> 7.0.1'
2626
end

0 commit comments

Comments
 (0)