Skip to content

Commit ace671e

Browse files
committed
ci: install test deps from setup.py
Includes special handling for the circleci/python:3.4 image, which doesn't setup PATH properly. This isn't worth fixing right now, as it is likely that we'll deprecate Python 3.4 support very soon.
1 parent 9f54e71 commit ace671e

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

.circleci/config.yml

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,7 @@ jobs:
4949
- image: circleci/python:2.7
5050
steps:
5151
- checkout
52-
- run: pip install --user .
53-
- run: sudo pip install coverage pylint==1.9.3 flake8 mock==3.0.5
52+
- run: pip install --user .[test]
5453
- run:
5554
name: Linting with Flake8
5655
command: |
@@ -59,9 +58,22 @@ jobs:
5958
- run: make e2e_test
6059

6160
test_34:
62-
<<: *test
6361
docker:
6462
- image: circleci/python:3.4
63+
steps:
64+
- checkout
65+
- run: pip install --user .[test]
66+
67+
# The circleci/python:3.4 image doesn't set PATH correctly, so we need to
68+
# install these by hand with sudo
69+
- sudo pip install coverage pylint==1.9.3 flake8 mock==3.0.5
70+
71+
- run:
72+
name: Linting with Flake8
73+
command: |
74+
git diff origin/master..HEAD analytics | flake8 --diff --max-complexity=10 analytics
75+
- run: make test
76+
- run: make e2e_test
6577

6678
test_35:
6779
<<: *test

0 commit comments

Comments
 (0)