UserAgent fix (#313)

bsneed · web-flow · commit 63137cdc59e5 · 2024-03-19T14:23:05.000-07:00
diff --git a/Sources/Segment/Plugins/Platforms/Vendors/AppleUtils.swift b/Sources/Segment/Plugins/Platforms/Vendors/AppleUtils.swift
@@ -249,11 +249,8 @@ internal class MacOSVendorSystem: VendorSystem {
         // It has to be fetched on the main thread, so we've spun it off
         // async and cache it when it comes back.
         if Self.asyncUserAgent == nil {
-            // it's failing tests because it never comes back; they get stuck.
-            if isUnitTesting == false {
-                DispatchQueue.main.async {
-                    Self.asyncUserAgent = WKWebView().value(forKey: "userAgent") as? String
-                }
+            DispatchQueue.main.async {
+                Self.asyncUserAgent = WKWebView().value(forKey: "userAgent") as? String
             }
         }
         return Self.asyncUserAgent

Original file line number	Diff line number	Diff line change
`@@ -249,11 +249,8 @@ internal class MacOSVendorSystem: VendorSystem {`
`249`	`249`	`// It has to be fetched on the main thread, so we've spun it off`
`250`	`250`	`// async and cache it when it comes back.`
`251`	`251`	`if Self.asyncUserAgent == nil {`
`252`		`- // it's failing tests because it never comes back; they get stuck.`
`253`		`- if isUnitTesting == false {`
`254`		`- DispatchQueue.main.async {`
`255`		`- Self.asyncUserAgent = WKWebView().value(forKey: "userAgent") as? String`
`256`		`- }`
	`252`	`+ DispatchQueue.main.async {`
	`253`	`+ Self.asyncUserAgent = WKWebView().value(forKey: "userAgent") as? String`
`257`	`254`	`}`
`258`	`255`	`}`
`259`	`256`	`return Self.asyncUserAgent`