Skip to content

Network object is missing carrier information #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
215eight opened this issue Apr 11, 2022 · 3 comments
Closed

Network object is missing carrier information #137

215eight opened this issue Apr 11, 2022 · 3 comments
Assignees
Labels

Comments

@215eight
Copy link

Describe the bug

In analytics-swift the network object does not include the carrier property whereas analytics-ios did. Below a comparison of both objects

analytics-ios v4.1.3

"library": {
      "name": "analytics-ios",
      "version": "4.1.3"
    },
    "locale": "en-US",
    "network": {
      "carrier": "T-Mobile",
      "cellular": true,
      "wifi": false
    }

analytics-swift v1.2.0

library": {
      "name": "analytics-swift",
      "version": "1.2.0"
    },
    "locale": "en-US",
    "network": {
      "bluetooth": false,
      "cellular": true,
      "wifi": false
    }

To Reproduce
Steps to reproduce the behavior:

  1. Using the analytics-swift library log an event
  2. The event metadata will not include the carrier property in the network object

Expected behavior
The network metadata should be consistent between analytics-ios and analytics-swift SDKs. This is seen as a regression issue after upgrading to the new package.

Platform (please complete the following information):

  • Library Version in use: v1.2.0
  • Platform being tested: iOS
  • Integrations in use: N/A

Additional context
N/A

@bsneed
Copy link
Contributor

bsneed commented Apr 12, 2022

@215eight cellularServiceProvider was deprecated in iOS 12. We made the decision to not include this information because of the format changes that would be required in switching over to serviceSubscriberCellularProviders.

@bsneed bsneed closed this as completed Apr 12, 2022
@215eight
Copy link
Author

Thanks a lot for the background on the decision here. As a customer that is upgrading from the 'analytics-iosto theanalytics-swiftlibrary this is seen as a regression issue because thecarrier` information was used before and is now no longer present. Is there a workaround you can offer?

Also, should I open a feature request to keep this in the roadmap in case it is also useful for other customers?

@bsneed
Copy link
Contributor

bsneed commented Apr 12, 2022

@215eight No problem. I can write a sample plugin that would live in your code to get this information in there and make it available to everyone via the /examples folder. Should just take a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants