Skip to content

TrackDeeplinks property #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benMohamed opened this issue Feb 23, 2023 · 1 comment · Fixed by #196
Closed

TrackDeeplinks property #194

benMohamed opened this issue Feb 23, 2023 · 1 comment · Fixed by #196
Assignees
@bsneed
Labels
triage

Comments

@benMohamed
Copy link

benMohamed commented Feb 23, 2023 •
edited
Loading

Hello,
I have noticed that changing the value of 'trackDeeplinks' to true or false does not have any effect.
Upon examining the code, I found that it only stores a boolean value.
@bsneed
Copy link
Contributor

bsneed commented Feb 27, 2023

Looks like that was an oversight on our part by not removing it. Between UIKit, SwiftUI and some nuances of specific platforms we felt that this was better done manually by developers since we couldn't really do it automatically across the board anymore. Please see the openURL method on the analytics class. I'll make a PR to remove this flag.

@bsneed bsneed mentioned this issue Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsneed bsneed

Labels
triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed trackDeepLinks from configuration segmentio/analytics-swift
2 participants
@bsneed @benMohamed