-
Notifications
You must be signed in to change notification settings - Fork 96
Support Swift's Set
as a JSON type
#198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It might be nice to support all types of |
Thanks @jnpdx & @rtharston! I'll have a look at this and get back to you guys shortly. |
I handled |
That's great! Thanks! The Collection and Sequence idea was just if it was simple. Set is the common one. 😄 |
Thanks so much! |
No problem! Thank you guys for the report! |
Is your feature request related to a problem? Please describe.
track(name: String, properties: [String: Any]? = nil)
will crash if one of theAny
is a SwiftSet
. It will not crash if that same property is anArray
.Describe the solution you'd like
Because to JSON,
Array
andSet
are identical, it would be nice if Segment'sJSON
type could encodeSet
without crashingDescribe alternatives you've considered
At this point, we just ensure we're always sending an
Array
Additional context
N/A
The text was updated successfully, but these errors were encountered: