Skip to content

Respect the port from Resolver in Dialer. #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hoveychen opened this issue Mar 13, 2019 · 2 comments
Closed

Respect the port from Resolver in Dialer. #231

hoveychen opened this issue Mar 13, 2019 · 2 comments
Assignees
@dominicbarnes
Labels
enhancement

Comments

@hoveychen
Copy link

hoveychen commented Mar 13, 2019 •
edited
Loading

We'd like to implement the Resolver interface to adapt our name discovery system.
Our name resolving sys returns not only host but also port. However, the current Dialer implementation abandons the resolved port. Would we add an option to opt in port resolving?
@achille-roussel achille-roussel self-assigned this Mar 21, 2019
@achille-roussel
Copy link
Contributor

@hoveychen this is a good idea that could help integrate with more advanced service discovery mechanisms.

Would you be able to submit a patch for this?

@dominicbarnes dominicbarnes mentioned this issue Oct 21, 2020
Merged
@dominicbarnes
Copy link
Contributor

With #545 you should be able to use this functionality in v0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominicbarnes dominicbarnes

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dominicbarnes @achille-roussel @hoveychen