--xvfb breaks the --reuse-session / --rs option

[smanenti]

When using the --xvfb option on a Linux environment (without desktop), the option --reuse-session has no effet, and the Chrome browser is re-launched on each tests.

More context:
We're using Pytest/SeleniumBase on a Jenkins environment to run our tests.
Jenkins is running on a Linux OS, without desktop, so we are using the --xvfb option, in addition to the --reuse-session to faster our tests.

We have confirmed that the PID of the Chrome browser is updated between tests, indicating that the Chrome browser instance is restarted.

Steps to reproduce

1. Write two different tests on a same class:
2. Test 1 is opening a specific URL
3. Test 2 is asserting this specific URL (which can only work if --reuse-session is enabled)
4. Execute the test (on the specified environment) with the option --xvfb + --reuse-session

Expected behavior

1. Test 2 must pass, as the Chrome is expected to be reused between Test 1 and Test 2

Actual behavior

1. Test 2 is failing, as the reuse-session is affected by the XVFB option (Chrome browser is relaunched)

Workaround

1. Replace the --xvfb option with --headless

[mdmintz]

Thanks for reporting this. I'm looking into a possible fix.
Likely caused by stopping and starting Xvfb between tests.
I'll need to figure out a way to keep Xvfb open in the same way as the reused browser.

[mdmintz]

This was resolved in 4.34.0 - https://github.com/seleniumbase/SeleniumBase/releases/tag/v4.34.0

[smanenti]

Thanks for fixing this issue so quickly!

[makifermis]

Bravo for this remarkable quick reaction @mdmintz, and thank you ! 👏