Skip to content

Commit 904b8ea

Browse files
committed
chart: not patch KEDA objects if autoscaling disabled
Fix: #2268 Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent 2f0f249 commit 904b8ea

File tree

4 files changed

+3
-5
lines changed

4 files changed

+3
-5
lines changed

Diff for: charts/selenium-grid/templates/patch-keda/patch-keda-objects-job.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{- if $.Values.autoscaling.patchObjectFinalizers.enabled }}
1+
{{- if and (eq (include "seleniumGrid.useKEDA" $) "true") $.Values.autoscaling.patchObjectFinalizers.enabled }}
22
apiVersion: batch/v1
33
kind: Job
44
metadata:

Diff for: charts/selenium-grid/templates/rbac-role.yaml renamed to charts/selenium-grid/templates/patch-keda/rbac-role.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{- if $.Values.rbacRole.create }}
1+
{{- if and (eq (include "seleniumGrid.useKEDA" $) "true") $.Values.autoscaling.patchObjectFinalizers.enabled }}
22
apiVersion: rbac.authorization.k8s.io/v1
33
kind: Role
44
metadata:

Diff for: charts/selenium-grid/templates/rbac-rolebinding.yaml renamed to charts/selenium-grid/templates/patch-keda/rbac-rolebinding.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{- if $.Values.rbacRoleBinding.create }}
1+
{{- if and (eq (include "seleniumGrid.useKEDA" $) "true") $.Values.autoscaling.patchObjectFinalizers.enabled }}
22
apiVersion: rbac.authorization.k8s.io/v1
33
kind: RoleBinding
44
metadata:

Diff for: charts/selenium-grid/values.yaml

-2
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ serviceAccount:
7474

7575
# RBAC settings
7676
rbacRole:
77-
create: true
7877
# nameOverride:
7978
annotations: {}
8079
rules:
@@ -95,7 +94,6 @@ rbacRole:
9594
verbs: [get, list, patch, update, delete]
9695

9796
rbacRoleBinding:
98-
create: true
9997
# nameOverride:
10098
annotations: {}
10199
roleRef:

0 commit comments

Comments
 (0)