Skip to content

Commit d01680c

Browse files
committed
K8s: Update config components.subPath to components.router.subPath
Since `subPath` is a config belongs to Router, not common for all components. Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent 325307a commit d01680c

File tree

9 files changed

+12
-11
lines changed

9 files changed

+12
-11
lines changed

Diff for: charts/selenium-grid/CONFIGURATION.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ A Helm chart for creating a Selenium Grid Server in Kubernetes
173173
| components.router.imageTag | string | `nil` | Router image tag (this overwrites global.seleniumGrid.imageTag parameter) |
174174
| components.router.imagePullPolicy | string | `"IfNotPresent"` | Image pull policy (see https://kubernetes.io/docs/concepts/containers/images/#updating-images) |
175175
| components.router.imagePullSecret | string | `""` | Image pull secret (see https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/) |
176+
| components.router.subPath | string | `""` | Custom sub path for Router |
176177
| components.router.disableUI | bool | `false` | Disable the Grid UI |
177178
| components.router.extraEnvironmentVariables | list | `[]` | Specify extra environment variables for Router |
178179
| components.router.extraEnvFrom | list | `[]` | Specify extra environment variables from ConfigMap and Secret for Router |
@@ -284,7 +285,6 @@ A Helm chart for creating a Selenium Grid Server in Kubernetes
284285
| components.sessionQueue.tolerations | list | `[]` | Tolerations for Session Queue pods |
285286
| components.sessionQueue.nodeSelector | object | `{}` | Node selector for Session Queue pods |
286287
| components.sessionQueue.priorityClassName | string | `""` | Priority class name for Session Queue pods |
287-
| components.subPath | string | `""` | Custom sub path for all components |
288288
| components.extraEnvironmentVariables | list | `[]` | Custom environment variables for all components |
289289
| components.extraEnvFrom | list | `[]` | Custom environment variables by sourcing entire configMap, Secret, etc. for all components |
290290
| hub.imageRegistry | string | `nil` | Registry to pull the image (this overwrites global.seleniumGrid.imageRegistry parameter) |

Diff for: charts/selenium-grid/templates/_helpers.tpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,7 @@ Graphql Url for internal monitoring exporter
762762
{{- define "seleniumGrid.url.subPath" -}}
763763
{{- $subPath := "" -}}
764764
{{- if $.Values.isolateComponents -}}
765-
{{- $subPath = default $subPath $.Values.components.subPath -}}
765+
{{- $subPath = default $subPath $.Values.components.router.subPath -}}
766766
{{- else -}}
767767
{{- $subPath = default $subPath $.Values.hub.subPath -}}
768768
{{- end -}}

Diff for: charts/selenium-grid/templates/router-deployment.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ spec:
6161
value: '{{ template "seleniumGrid.sessionQueue.fullname" . }}.{{ .Release.Namespace }}'
6262
- name: SE_SESSION_QUEUE_PORT
6363
value: {{ .Values.components.sessionQueue.port | quote }}
64-
{{- with .Values.components.subPath }}
64+
{{- with .Values.components.router.subPath }}
6565
- name: SE_SUB_PATH
6666
value: {{ include "utils.trimTrailingSlash" . | quote }}
6767
{{- end }}

Diff for: charts/selenium-grid/values.yaml

+2-3
Original file line numberDiff line numberDiff line change
@@ -397,6 +397,8 @@ components:
397397
# -- Image pull secret (see https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/)
398398
imagePullSecret: ""
399399

400+
# -- Custom sub path for Router
401+
subPath: ""
400402
# -- Disable the Grid UI
401403
disableUI: false
402404
# -- Specify extra environment variables for Router
@@ -691,9 +693,6 @@ components:
691693
# -- Priority class name for Session Queue pods
692694
priorityClassName: ""
693695

694-
# -- Custom sub path for all components
695-
subPath: ""
696-
697696
# -- Custom environment variables for all components
698697
extraEnvironmentVariables: []
699698
# - name: SE_JAVA_OPTS

Diff for: tests/charts/ci/base-subPath-values.yaml

+2-1
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,5 @@ hub:
2323
subPath: *gridAppRoot
2424

2525
components:
26-
subPath: *gridAppRoot
26+
router:
27+
subPath: *gridAppRoot

Diff for: tests/charts/refValues/sample-aws.yaml

+2-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ hub:
4949
subPath: *gridAppRoot
5050

5151
components:
52-
subPath: *gridAppRoot
52+
router:
53+
subPath: *gridAppRoot
5354

5455
chromeNode:
5556
extraEnvironmentVariables: &extraEnvironmentVariablesNodes

Diff for: tests/charts/refValues/simplex-minikube.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ hub:
6262
serviceType: NodePort
6363

6464
components:
65-
subPath: *gridAppRoot
6665
router:
66+
subPath: *gridAppRoot
6767
serviceType: NodePort
6868

6969
chromeNode:

Diff for: tests/charts/templates/render/dummy.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ ingress:
9292
isolateComponents: true
9393

9494
components:
95-
subPath: *gridAppRoot
9695
router:
96+
subPath: *gridAppRoot
9797
disableUI: true
9898
annotations:
9999
"restartOnUpdate": "true"

Diff for: tests/charts/templates/render/dummy_solution.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ selenium-grid:
9393
isolateComponents: true
9494

9595
components:
96-
subPath: *gridAppRoot
9796
router:
97+
subPath: *gridAppRoot
9898
disableUI: true
9999
serviceType: NodePort
100100
extraEnvironmentVariables:

0 commit comments

Comments
 (0)