Skip to content

Commit 01bf9a0

Browse files
committed
Fixing capabilities constructor from a map to not modify the original map
1 parent 59d3940 commit 01bf9a0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Diff for: java/client/src/org/openqa/selenium/remote/DesiredCapabilities.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ public DesiredCapabilities() {
5151
}
5252

5353
public DesiredCapabilities(Map<String, ?> rawMap) {
54+
capabilities.putAll(rawMap);
55+
5456
if (rawMap.containsKey(LOGGING_PREFS) && rawMap.get(LOGGING_PREFS) instanceof Map) {
5557
LoggingPreferences prefs = new LoggingPreferences();
5658
Map<String, String> prefsMap = (Map<String, String>) rawMap.get(LOGGING_PREFS);
@@ -59,10 +61,8 @@ public DesiredCapabilities(Map<String, ?> rawMap) {
5961
prefs.enable(logType, LogLevelMapping.toLevel(prefsMap.get(logType)));
6062
}
6163
capabilities.put(LOGGING_PREFS, prefs);
62-
// So it does not get added twice
63-
rawMap.remove(LOGGING_PREFS);
6464
}
65-
capabilities.putAll(rawMap);
65+
6666
Object value = capabilities.get(PLATFORM);
6767
if (value instanceof String) {
6868
try {

0 commit comments

Comments
 (0)