Skip to content

Commit 04e6815

Browse files
committed
Removing Firefox profile cleaning step in .NET bindings
Firefox used to require launching to clean up potential issues with the anonymous temporary profile that we use with the driver. This is no longer the case.
1 parent 144f5ee commit 04e6815

File tree

2 files changed

+0
-23
lines changed

2 files changed

+0
-23
lines changed

Diff for: dotnet/src/webdriver/Firefox/FirefoxBinary.cs

-22
Original file line numberDiff line numberDiff line change
@@ -219,28 +219,6 @@ public void WaitForProcessExit()
219219
this.process.WaitForExit();
220220
}
221221

222-
/// <summary>
223-
/// Initializes the binary with the specified profile.
224-
/// </summary>
225-
/// <param name="profile">The <see cref="FirefoxProfile"/> to use to initialize the binary.</param>
226-
public void Clean(FirefoxProfile profile)
227-
{
228-
if (profile == null)
229-
{
230-
throw new ArgumentNullException("profile", "profile cannot be null");
231-
}
232-
233-
this.StartProfile(profile, "-silent");
234-
try
235-
{
236-
this.WaitForProcessExit();
237-
}
238-
catch (ThreadInterruptedException e)
239-
{
240-
throw new WebDriverException("Thread was interrupted", e);
241-
}
242-
}
243-
244222
/// <summary>
245223
/// Stops the execution of this <see cref="FirefoxBinary"/>, terminating the process if necessary.
246224
/// </summary>

Diff for: dotnet/src/webdriver/Firefox/FirefoxDriverServer.cs

-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ public void Start()
8989
int portToUse = DetermineNextFreePort(this.host, this.profile.Port);
9090
this.profile.Port = portToUse;
9191
this.profile.WriteToDisk();
92-
this.process.Clean(this.profile);
9392
this.process.StartProfile(this.profile, new string[] { "-foreground" });
9493

9594
this.SetAddress(portToUse);

0 commit comments

Comments
 (0)