Skip to content

Commit 1b129aa

Browse files
committed
setAuthentication -> setAlertCredentials
1 parent 91b95b9 commit 1b129aa

File tree

6 files changed

+7
-7
lines changed

6 files changed

+7
-7
lines changed

Diff for: java/client/src/org/openqa/selenium/remote/DriverCommand.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public interface DriverCommand {
9393
String DISMISS_ALERT = "dismissAlert";
9494
String GET_ALERT_TEXT = "getAlertText";
9595
String SET_ALERT_VALUE = "setAlertValue";
96-
String SET_ALERT_AUTHENTICATION = "setAuthentication";
96+
String SET_ALERT_CREDENTIALS = "setAlertCredentials";
9797

9898
String SET_TIMEOUT = "setTimeout";
9999
String IMPLICITLY_WAIT = "implicitlyWait";

Diff for: java/client/src/org/openqa/selenium/remote/RemoteWebDriver.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -943,7 +943,7 @@ public void sendKeys(String keysToSend) {
943943
*/
944944
@Beta
945945
public void authenticateUsing(Credentials credentials) {
946-
execute(DriverCommand.SET_ALERT_AUTHENTICATION, ImmutableMap
946+
execute(DriverCommand.SET_ALERT_CREDENTIALS, ImmutableMap
947947
.of("username", credentials.getUserPrincipal().getName(), "password",
948948
credentials.getPassword()));
949949
}

Diff for: java/client/src/org/openqa/selenium/remote/http/JsonHttpCommandCodec.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public JsonHttpCommandCodec() {
9797
defineCommand(DISMISS_ALERT, post("/session/:sessionId/dismiss_alert"));
9898
defineCommand(GET_ALERT_TEXT, get("/session/:sessionId/alert_text"));
9999
defineCommand(SET_ALERT_VALUE, post("/session/:sessionId/alert_text"));
100-
defineCommand(SET_ALERT_AUTHENTICATION, post("/session/:sessionId/authenticate"));
100+
defineCommand(SET_ALERT_CREDENTIALS, post("/session/:sessionId/alert_credentials"));
101101

102102
defineCommand(EXECUTE_SCRIPT, post("/session/:sessionId/execute"));
103103
defineCommand(EXECUTE_ASYNC_SCRIPT, post("/session/:sessionId/execute_async"));

Diff for: py/selenium/webdriver/common/alert.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,4 +101,4 @@ def authenticate(self, username, password):
101101
-username: string to be set in the username section of the dialog
102102
-password: string to be set in the password section of the dialog
103103
"""
104-
self.driver.execute(Command.SET_ALERT_AUTHENTICATION, {'username':username, 'password':password})
104+
self.driver.execute(Command.SET_ALERT_CREDENTIALS, {'username':username, 'password':password})

Diff for: py/selenium/webdriver/remote/command.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ class Command(object):
9797
ACCEPT_ALERT = "acceptAlert"
9898
SET_ALERT_VALUE = "setAlertValue"
9999
GET_ALERT_TEXT = "getAlertText"
100-
SET_ALERT_AUTHENTICATION = "setAuthentication"
100+
SET_ALERT_CREDENTIALS = "setAlertCredentials"
101101

102102
# Advanced user interactions
103103
CLICK = "mouseClick"

Diff for: py/selenium/webdriver/remote/remote_connection.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -275,8 +275,8 @@ def __init__(self, remote_server_addr, keep_alive=False):
275275
('POST', '/session/$sessionId/alert_text'),
276276
Command.GET_ALERT_TEXT:
277277
('GET', '/session/$sessionId/alert_text'),
278-
Command.SET_ALERT_AUTHENTICATION:
279-
('POST', '/session/$sessionId/authenticate'),
278+
Command.SET_ALERT_CREDENTIALS:
279+
('POST', '/session/$sessionId/alert_credentials'),
280280
Command.CLICK:
281281
('POST', '/session/$sessionId/click'),
282282
Command.DOUBLE_CLICK:

0 commit comments

Comments
 (0)