Skip to content

Commit 2051f9a

Browse files
committed
Fixing bug in IE screenshot handling due to Windows hook refactor.
1 parent 5e73475 commit 2051f9a

File tree

5 files changed

+9
-0
lines changed

5 files changed

+9
-0
lines changed

Diff for: cpp/iedriver/CommandHandlers/ScreenshotCommandHandler.h

+5
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,13 @@ class ScreenshotCommandHandler : public IECommandHandler {
180180

181181
HookProcessor hook;
182182
hook.Initialize(hook_settings);
183+
183184
hook.PushData(sizeof(max_image_dimensions), &max_image_dimensions);
184185
browser->SetWidth(max_image_dimensions.right);
186+
187+
// Must re-push data because the resize causes a message to the
188+
// IE window, and reading the data clears the buffer.
189+
hook.PushData(sizeof(max_image_dimensions), &max_image_dimensions);
185190
browser->SetHeight(max_image_dimensions.bottom);
186191

187192
// Capture the window's canvas to a DIB.

Diff for: cpp/iedriverserver/CHANGELOG

+4
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ available via the project downloads page. Changes in "revision" field indicate
99
private releases checked into the prebuilts directory of the source tree, but
1010
not made generally available on the downloads page.
1111

12+
v2.46.0.8
13+
=========
14+
* Fixed bug in screenshot handling due to Windows hook refactor.
15+
1216
v2.46.0.7
1317
=========
1418
* Fixed cookie delete bug for related domains.

Diff for: cpp/iedriverserver/IEDriverServer.rc

0 Bytes
Binary file not shown.

Diff for: cpp/prebuilt/Win32/Release/IEDriverServer.exe

0 Bytes
Binary file not shown.

Diff for: cpp/prebuilt/x64/Release/IEDriverServer.exe

0 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)