rb: deal with invalid type argument

When an invalid type argument is given, an ArgumentError should be raised.

Signed-off-by: Andreas Tolfsen <[email protected]>

Author: jimvm

rb/lib/selenium/webdriver/common/driver_extensions/has_network_connection.rb

@@ -13,6 +13,8 @@ def network_connection_type
         end
 
         def network_connection_type=(connection_type)
+          raise ArgumentError, "Invalid connection type" unless valid_type? connection_type
+
           connection_value = type_to_values[connection_type]
 
           @bridge.setNetworkConnection connection_value
@@ -27,6 +29,10 @@ def type_to_values
           def values_to_type
             type_to_values.invert
           end
+
+          def valid_type?(type)
+            type_to_values.keys.include? type
+          end
       end
     end
   end

rb/spec/unit/selenium/webdriver/common/driver_extensions/has_network_connection_spec.rb

@@ -30,6 +30,11 @@ class FakeDriver
 
             driver.network_connection_type = :airplane_mode
           end
+
+          it "returns an error when an invalid argument is given" do
+            expect { driver.network_connection_type = :something }.
+              to raise_error(ArgumentError, "Invalid connection type")
+          end
         end
       end
     end