Skip to content

Commit 37d0874

Browse files
juangjsevaseva
authored andcommitted
Disable some atoms tests that are broken in Safari.
Signed-off-by: Seva Lotoshnikov <[email protected]>
1 parent 0872f54 commit 37d0874

File tree

1 file changed

+24
-4
lines changed

1 file changed

+24
-4
lines changed

Diff for: javascript/atoms/test/select_test.html

+24-4
Original file line numberDiff line numberDiff line change
@@ -191,13 +191,19 @@
191191
var testClickCanToggleOptionsInAMultiSelect =
192192
// Disabled on Chrome due to
193193
// https://code.google.com/p/chromedriver/issues/detail?id=1073
194-
goog.userAgent.product.CHROME ? goog.nullFunction :
194+
// Disabled on Safari due to
195+
// https://github.com/SeleniumHQ/selenium/issues/461
196+
(goog.userAgent.product.CHROME || goog.userAgent.product.SAFARI) ?
197+
goog.nullFunction :
195198
goog.partial(canToggleOptionsInAMultiSelect, bot.action.click);
196199

197200
var testTapCanToggleOptionsInAMultiSelect =
198201
// Disabled on Chrome due to
199202
// https://code.google.com/p/chromedriver/issues/detail?id=1073
200-
goog.userAgent.product.CHROME ? goog.nullFunction :
203+
// Disabled on Safari due to
204+
// https://github.com/SeleniumHQ/selenium/issues/461
205+
(goog.userAgent.product.CHROME || goog.userAgent.product.SAFARI) ?
206+
goog.nullFunction :
201207
goog.partial(canToggleOptionsInAMultiSelect, bot.action.tap);
202208

203209
function canToggleCheckboxes(action) {
@@ -328,12 +334,19 @@
328334
}
329335

330336
var testClickCanSelectOptionWhenDefaultPrevented =
337+
// Disabled on Safari due to
338+
// https://github.com/SeleniumHQ/selenium/issues/461
339+
goog.userAgent.product.SAFARI ?
340+
goog.nullFunction :
331341
goog.partial(canSelectOptionWhenDefaultPrevented, bot.action.click);
332342

333343
var testTapCanSelectOptionWhenDefaultPrevented =
334344
// Disabled on Chrome due to
335345
// https://code.google.com/p/chromedriver/issues/detail?id=1073
336-
goog.userAgent.product.CHROME ? goog.nullFunction :
346+
// Disabled on Safari due to
347+
// https://github.com/SeleniumHQ/selenium/issues/461
348+
(goog.userAgent.product.CHROME || goog.userAgent.product.SAFARI) ?
349+
goog.nullFunction :
337350
goog.partial(canSelectOptionWhenDefaultPrevented, bot.action.tap);
338351

339352
function cannotSelectCheckboxWhenDefaultPrevented(action) {
@@ -528,12 +541,19 @@
528541
}
529542

530543
var testClickTogglesByTheTimeChangeEventFires =
544+
// Disabled on Safari due to
545+
// https://github.com/SeleniumHQ/selenium/issues/461
546+
goog.userAgent.product.SAFARI ?
547+
goog.nullFunction :
531548
goog.partial(togglesByTheTimeChangeEventFires, bot.action.click);
532549

533550
var testTapTogglesByTheTimeChangeEventFires =
534551
// Disabled on Chrome due to
535552
// https://code.google.com/p/chromedriver/issues/detail?id=1073
536-
goog.userAgent.product.CHROME ? goog.nullFunction :
553+
// Disabled on Safari due to
554+
// https://github.com/SeleniumHQ/selenium/issues/461
555+
(goog.userAgent.product.CHROME || goog.userAgent.product.SAFARI) ?
556+
goog.nullFunction :
537557
goog.partial(togglesByTheTimeChangeEventFires, bot.action.tap);
538558
</script>
539559
</head>

0 commit comments

Comments
 (0)