Skip to content

Commit 6a34eac

Browse files
committed
Deflake a test.
I don't think, by contract, page MUST be loaded after driver.executeScript("window.open(url, 'newWindow')"); driver.switchTo().window("newWindow"); returns. This has been flaky with Chrome on Windows XP, specifically.
1 parent e45d92f commit 6a34eac

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

java/client/test/org/openqa/selenium/PageLoadingTest.java

+1
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,7 @@ public void testShouldDoNothingIfThereIsNothingToGoBackTo() {
264264
"window.open('" + pages.formPage + "', 'newWindow')");
265265
wait.until(newWindowIsOpened(currentWindowHandles));
266266
driver.switchTo().window("newWindow");
267+
wait.until(titleIs("We Leave From Here"));
267268
String originalTitle = driver.getTitle();
268269
driver.get(pages.blankPage);
269270
wait.until(not(titleIs(originalTitle)));

0 commit comments

Comments
 (0)