Skip to content

Commit 6a7bb83

Browse files
committed
On Behalf of Jason Morrison (jasonm): when using desired capabilities and chrome options together, attempt to merge rather than squash.
Fixes Issue #7389
1 parent 0dce277 commit 6a7bb83

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

py/selenium/webdriver/chrome/webdriver.py

+9-7
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,16 @@ def __init__(self, executable_path="chromedriver", port=0,
4545
- chrome_options: this takes an instance of ChromeOptions
4646
"""
4747
if chrome_options is None:
48-
options = Options()
48+
if desired_capabilities is None:
49+
desired_capabilities = Options().to_capabilities()
50+
else:
51+
# desired_capabilities stays as passed
52+
pass
4953
else:
50-
options = chrome_options
51-
52-
if desired_capabilities is not None:
53-
desired_capabilities.update(options.to_capabilities())
54-
else:
55-
desired_capabilities = options.to_capabilities()
54+
if desired_capabilities is None:
55+
desired_capabilities = options.to_capabilities()
56+
else:
57+
desired_capabilities.update(options.to_capabilities())
5658

5759
self.service = Service(executable_path, port=port,
5860
service_args=service_args, log_path=service_log_path)

0 commit comments

Comments
 (0)