ff: Escaping quotes in preferences. Fixes issue 8273

Author: barancev

Diff for: java/client/src/org/openqa/selenium/firefox/Preferences.java

@@ -46,12 +46,12 @@ class Preferences {
    */
   private static final String MAX_SCRIPT_RUN_TIME_KEY = "dom.max_script_run_time";
   private static final int DEFAULT_MAX_SCRIPT_RUN_TIME = 30;
-  
+
   /**
    * This pattern is used to parse preferences in user.js. It is intended to match all preference
    * lines in the format generated by Firefox; it won't necessarily match all possible lines that
    * Firefox will parse.
-   * 
+   *
    * e.g. if you have a line with extra spaces after the end-of-line semicolon, this pattern will
    * not match that line because Firefox never generates lines like that.
    */
@@ -172,17 +172,22 @@ public void addTo(FirefoxProfile profile) {
   public void writeTo(Writer writer) throws IOException {
     for (Map.Entry<String, Object> pref : allPrefs.entrySet()) {
       writer.append("user_pref(\"").append(pref.getKey()).append("\", ");
-      writer.append(valueAsPreference(pref.getValue()).replaceAll("\\\\", "\\\\\\\\"));
+      writer.append(valueAsPreference(pref.getValue()));
       writer.append(");\n");
     }
   }
 
   private String valueAsPreference(Object value) {
     if (value instanceof String) {
-      return "\"" + value + "\"";
+      return "\"" + escapeValueAsPreference((String) value) + "\"";
+    } else {
+      return escapeValueAsPreference(String.valueOf(value));
     }
 
-    return String.valueOf(value);
+  }
+
+  private String escapeValueAsPreference(String value) {
+    return value.replaceAll("\\\\", "\\\\\\\\").replaceAll("\"", "\\\\\"");
   }
 
   private Object preferenceAsValue(String toConvert) {