Check for visibility:collapse

Fixes #530

Author: jleyba

Diff for: javascript/atoms/dom.js

@@ -596,8 +596,9 @@ bot.dom.isShown = function(elem, opt_ignoreOpacity) {
     return false;
   }
 
-  // Any element with hidden visibility is not shown.
-  if (bot.dom.getEffectiveStyle(elem, 'visibility') == 'hidden') {
+  // Any element with hidden/collapsed visibility is not shown.
+  var visibility = bot.dom.getEffectiveStyle(elem, 'visibility');
+  if (visibility == 'collapse' || visibility == 'hidden') {
     return false;
   }
 

Diff for: javascript/atoms/test/shown_test.html

@@ -357,6 +357,29 @@
         assertFalse(isShown(elem));
       });
     }
+
+    function testTableRowDefaultVisibility() {
+      var elem = findElement({id: 'visible-row'});
+      assertTrue(isShown(elem));
+      assertTrue(isShown(elem.firstChild));
+    }
+
+    function testTableRowCollapsedVisibility() {
+      expectedFailures.expectFailureFor(
+          (goog.userAgent.IE && !goog.userAgent.isDocumentModeOrHigher(8)),
+          'IE does not support visibilty:collapsed until IE8');
+      var elem = findElement({id: 'collapsed-row'});
+      expectedFailures.run(function() {
+        assertFalse(isShown(elem));
+        assertFalse(isShown(elem.firstChild));
+      });
+    }
+
+    function testVisibleTableRowAfterCollapsedRow() {
+      var elem = findElement({id: 'post-collapsed-row'});
+      assertTrue(isShown(elem));
+      assertTrue(isShown(elem.firstChild));
+    }
   </script>
 
   <style type="text/css">
@@ -532,5 +555,10 @@
   </div>
 </div>
 <div id='html5hidden' hidden>This is not visible</div>
+<table>
+<tr id="visible-row"><td>a</td></tr>
+<tr id="collapsed-row" style="visibility:collapse"><td>b</td></tr>
+<tr id="post-collapsed-row"><td>c</td></tr>
+</table>
 </body>
 </html>

Diff for: javascript/atoms/test/text_table_test.html

@@ -25,6 +25,7 @@
     goog.require('bot.userAgent');
     goog.require('goog.array');
     goog.require('goog.dom');
+    goog.require('goog.testing.ExpectedFailures');
     goog.require('goog.testing.jsunit');
   </script>
   <style>
@@ -47,6 +48,15 @@
   var TD = goog.partial(goog.dom.createDom, goog.dom.TagName.TD, null);
   var P = goog.partial(goog.dom.createDom, goog.dom.TagName.P, null);
 
+  var expectedFailures;
+
+  function setUp() {
+    expectedFailures = new goog.testing.ExpectedFailures();
+  }
+
+  function tearDown() {
+    expectedFailures.handleTearDown();
+  }
 
   function testEmptyTable() {
     assertTextIs(TABLE(), '');
@@ -196,7 +206,24 @@
         "Table 2, Row 1, Cell 1 Table 2, Row 1, Cell 2",
         "Table 1, Row 3, Cell 1 Table 1, Row 3, Cell 2");
   }
+
+
+  function testTableWithCollapsedRows() {
+    expectedFailures.expectFailureFor(
+        (goog.userAgent.IE && !goog.userAgent.isDocumentModeOrHigher(8)),
+        'IE does not support visibilty:collapsed until IE8');
+    expectedFailures.run(function() {
+      assertTextIs(
+          goog.dom.getElement('collapsedTable'),
+          'a', 'c');
+    });
+  }
 </script>
+<table id="collapsedTable">
+  <tr><td>a</td></tr>
+  <tr style="visibility:collapse"><td>b</td></tr>
+  <tr><td>c</td></tr>
+</table>
 <table id="nestedTable">
   <tr>
       <td>