Skip to content

Commit 719bffd

Browse files
committed
Setting HtmlUnit to emulate FF24 by default
1 parent 3b2b574 commit 719bffd

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

java/client/src/org/openqa/selenium/htmlunit/HtmlUnitDriver.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ static BrowserVersion determineBrowserVersion(Capabilities capabilities) {
231231
}
232232

233233
if (BrowserType.FIREFOX.equals(browserName)) {
234-
return BrowserVersion.FIREFOX_17;
234+
return BrowserVersion.FIREFOX_24;
235235
}
236236

237237
if (BrowserType.CHROME.equals(browserName)) {

java/client/test/org/openqa/selenium/ClickTest.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ public void testCanClickAnImageMapArea() {
287287
}
288288

289289
@Test
290-
@Ignore(value = {HTMLUNIT, OPERA, OPERA_MOBILE, ANDROID, IPHONE, MARIONETTE}, reason
290+
@Ignore(value = {OPERA, OPERA_MOBILE, ANDROID, IPHONE, MARIONETTE}, reason
291291
= "Not tested against these browsers")
292292
public void testShouldBeAbleToClickOnAnElementGreaterThanTwoViewports() {
293293
String url = appServer.whereIs("click_too_big.html");
@@ -301,7 +301,7 @@ public void testShouldBeAbleToClickOnAnElementGreaterThanTwoViewports() {
301301
}
302302

303303
@Test
304-
@Ignore(value = {CHROME, HTMLUNIT, OPERA, OPERA_MOBILE, ANDROID, IPHONE, MARIONETTE}, reason
304+
@Ignore(value = {CHROME, OPERA, OPERA_MOBILE, ANDROID, IPHONE, MARIONETTE}, reason
305305
= "Chrome: failed, Firefox: failed with native events, others: not tested")
306306
public void testShouldBeAbleToClickOnAnElementInFrameGreaterThanTwoViewports() {
307307
assumeFalse(isFirefox(driver) && isNativeEventsEnabled(driver));
@@ -331,7 +331,7 @@ public void testShouldBeAbleToClickOnRTLLanguageLink() {
331331
}
332332

333333
@Test
334-
@Ignore(value = {HTMLUNIT, OPERA, OPERA_MOBILE, ANDROID, IPHONE, MARIONETTE}, reason
334+
@Ignore(value = {OPERA, OPERA_MOBILE, ANDROID, IPHONE, MARIONETTE}, reason
335335
= "not tested")
336336
public void testShouldBeAbleToClickOnLinkInAbsolutelyPositionedFooter() {
337337
String url = appServer.whereIs("fixedFooterNoScroll.html");
@@ -344,7 +344,7 @@ public void testShouldBeAbleToClickOnLinkInAbsolutelyPositionedFooter() {
344344
}
345345

346346
@Test
347-
@Ignore(value = {HTMLUNIT, OPERA, OPERA_MOBILE, ANDROID, IPHONE, MARIONETTE}, reason
347+
@Ignore(value = {OPERA, OPERA_MOBILE, ANDROID, IPHONE, MARIONETTE}, reason
348348
= "not tested")
349349
public void testShouldBeAbleToClickOnLinkInAbsolutelyPositionedFooterInQuirksMode() {
350350
String url = appServer.whereIs("fixedFooterNoScrollQuirksMode.html");

java/client/test/org/openqa/selenium/htmlunit/HtmlUnitCapabilitiesTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public void configurationViaDirectCapabilities() {
4444
new DesiredCapabilities(BrowserType.FIREFOX, "", Platform.ANY);
4545

4646
assertEquals(HtmlUnitDriver.determineBrowserVersion(firefoxCapabilities),
47-
BrowserVersion.FIREFOX_17);
47+
BrowserVersion.FIREFOX_24);
4848
}
4949

5050
@Test
@@ -53,7 +53,7 @@ public void configurationOfFirefoxViaRemote() {
5353
new DesiredCapabilities(BrowserType.HTMLUNIT, "firefox", Platform.ANY);
5454

5555
assertEquals(HtmlUnitDriver.determineBrowserVersion(firefoxCapabilities),
56-
BrowserVersion.FIREFOX_17);
56+
BrowserVersion.FIREFOX_24);
5757
}
5858

5959
@Test

0 commit comments

Comments
 (0)