Skip to content

Commit 7b1c21e

Browse files
jimvmandreastt
authored andcommittedMar 2, 2015
rb: remove unused HasBrowserConnection driver extension
This is related to this issue: https://code.google.com/p/selenium/issues/detail?id=7315 HasBrowserConnection is a driver extension that is only an option for the Android driver. The Selendroid JSON Wire implementation doesn't support the browser_connection method anymore, so all code related to this driver extension can be removed from the Ruby bindings. Here you can verify that the browser_connection method is not available anymore: https://github.com/selendroid/selendroid/wiki/JSON-Wire-Protocol:-Supported-Methods https://github.com/selendroid/selendroid/blob/master/selendroid-server/src/main/java/io/selendroid/server/AndroidServlet.java https://github.com/selendroid/selendroid/blob/master/selendroid-standalone/src/main/java/io/selendroid/server/SelendroidServlet.java Signed-off-by: Andreas Tolfsen <[email protected]>
1 parent 085aecb commit 7b1c21e

File tree

6 files changed

+0
-50
lines changed

6 files changed

+0
-50
lines changed
 

Diff for: ‎rb/lib/selenium/webdriver/android/bridge.rb

-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ def driver_extensions
3434
DriverExtensions::HasInputDevices,
3535
DriverExtensions::HasWebStorage,
3636
DriverExtensions::HasLocation,
37-
DriverExtensions::HasBrowserConnection,
3837
DriverExtensions::HasTouchScreen
3938
]
4039
end

Diff for: ‎rb/lib/selenium/webdriver/common.rb

-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
require 'selenium/webdriver/common/html5/session_storage'
2929
require 'selenium/webdriver/common/driver_extensions/takes_screenshot'
3030
require 'selenium/webdriver/common/driver_extensions/rotatable'
31-
require 'selenium/webdriver/common/driver_extensions/has_browser_connection'
3231
require 'selenium/webdriver/common/driver_extensions/has_input_devices'
3332
require 'selenium/webdriver/common/driver_extensions/has_web_storage'
3433
require 'selenium/webdriver/common/driver_extensions/has_location'

Diff for: ‎rb/lib/selenium/webdriver/common/driver_extensions/has_browser_connection.rb

-17
This file was deleted.

Diff for: ‎rb/lib/selenium/webdriver/remote/bridge.rb

-8
Original file line numberDiff line numberDiff line change
@@ -321,14 +321,6 @@ def setLocation(lat, lon, alt)
321321
execute :setLocation, {}, :location => loc
322322
end
323323

324-
def isBrowserOnline
325-
execute :isBrowserOnline
326-
end
327-
328-
def setBrowserOnline(bool)
329-
execute :setBrowserOnline, {}, :state => bool
330-
end
331-
332324
#
333325
# javascript execution
334326
#

Diff for: ‎rb/lib/selenium/webdriver/remote/commands.rb

-3
Original file line numberDiff line numberDiff line change
@@ -143,9 +143,6 @@ class Selenium::WebDriver::Remote::Bridge
143143
command :getAppCacheStatus, :get, "session/:session_id/application_cache/status"
144144
command :clearAppCache, :delete, "session/:session_id/application_cache/clear"
145145

146-
command :isBrowserOnline, :get, "session/:session_id/browser_connection"
147-
command :setBrowserOnline, :post, "session/:session_id/browser_connection"
148-
149146
command :getLocalStorageItem, :get, "session/:session_id/local_storage/key/:key"
150147
command :removeLocalStorageItem, :delete, "session/:session_id/local_storage/key/:key"
151148
command :getLocalStorageKeys, :get, "session/:session_id/local_storage"

Diff for: ‎rb/spec/integration/selenium/webdriver/browser_connection_spec.rb

-20
This file was deleted.

0 commit comments

Comments
 (0)
Please sign in to comment.