Implementing ability to clear file input fields (Firefox only; other browsers need to update atoms)

Author: barancev

Diff for: java/client/test/org/openqa/selenium/UploadTest.java

@@ -17,12 +17,17 @@
 
 package org.openqa.selenium;
 
+import static org.junit.Assert.assertEquals;
 import static org.junit.Assume.assumeFalse;
 import static org.openqa.selenium.Platform.ANDROID;
 import static org.openqa.selenium.WaitingConditions.elementTextToEqual;
 import static org.openqa.selenium.support.ui.ExpectedConditions.not;
 import static org.openqa.selenium.support.ui.ExpectedConditions.visibilityOf;
+import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
+import static org.openqa.selenium.testing.Ignore.Driver.HTMLUNIT;
+import static org.openqa.selenium.testing.Ignore.Driver.IE;
 import static org.openqa.selenium.testing.Ignore.Driver.MARIONETTE;
+import static org.openqa.selenium.testing.Ignore.Driver.PHANTOMJS;
 import static org.openqa.selenium.testing.Ignore.Driver.SAFARI;
 
 import com.google.common.base.Charsets;
@@ -75,6 +80,16 @@ public void testFileUploading() throws Exception {
     wait.until(elementTextToEqual(body, LOREM_IPSUM_TEXT));
   }
 
+  @Test
+  @Ignore(value = {CHROME, HTMLUNIT, IE, MARIONETTE, PHANTOMJS, SAFARI})
+  public void testCleanFileInput() throws Exception {
+    driver.get(pages.uploadPage);
+    WebElement element = driver.findElement(By.id("upload"));
+    element.sendKeys(testFile.getAbsolutePath());
+    element.clear();
+    assertEquals("", element.getAttribute("value"));
+  }
+
   private File createTmpFile(String content) throws IOException {
     File f = File.createTempFile("webdriver", "tmp");
     f.deleteOnExit();

Diff for: javascript/atoms/dom.js

@@ -409,6 +409,20 @@ bot.dom.isTextual = function(element) {
 };
 
 
+/**
+ * @param {!Element} element The element to check.
+ * @return {boolean} Whether the element is a file input.
+ */
+bot.dom.isFileInput = function(element) {
+  if (bot.dom.isElement(element, goog.dom.TagName.INPUT)) {
+    var type = element.type.toLowerCase();
+    return type == 'file';
+  }
+
+  return false;
+};
+
+
 /**
  * @param {!Element} element The element to check.
  * @return {boolean} Whether the element is contentEditable.
@@ -450,7 +464,7 @@ bot.dom.isContentEditable = function(element) {
  * @return {boolean} Whether the element accepts user-typed text.
  */
 bot.dom.isEditable = function(element) {
-  return bot.dom.isTextual(element) &&
+  return (bot.dom.isTextual(element) || bot.dom.isFileInput(element)) &&
       !bot.dom.getProperty(element, 'readOnly');
 };
 

Diff for: javascript/atoms/test/action_test.html

@@ -173,6 +173,13 @@
       assertThrows(goog.partial(bot.action.clear, e));
     }
 
+    function testClearingAFileInputShouldBeNoOp() {
+      var e = goog.dom.getElement('fileField');
+      doNotExpectChangeEvent(e);
+      bot.action.clear(e);
+      assertEquals('', e.value);
+    }
+
     function testSubmittingANonFormElementShouldResultInAnError() {
       assertThrows(goog.partial(bot.action.submit, document.body));
     }
@@ -255,6 +262,10 @@
       <label for="passwordField">Password field</label>
       <input type="password" id="passwordField">
     </div>
+    </div>
+      <label for="fileField">File field</label>
+      <input type="file" id="fileField">
+    </div>
   </form>
 
   <div id="log">