Implementing ability to set an arbitrary platform capability even if it can't be converted to Platform enum in DesiredCapability constructor from Map. Fixes issue 8333

Author: barancev

Diff for: java/client/src/org/openqa/selenium/remote/DesiredCapabilities.java

@@ -65,7 +65,11 @@ public DesiredCapabilities(Map<String, ?> rawMap) {
     capabilities.putAll(rawMap);
     Object value = capabilities.get(PLATFORM);
     if (value instanceof String) {
-      capabilities.put(PLATFORM, Platform.valueOf((String) value));
+      try {
+        capabilities.put(PLATFORM, Platform.fromString((String) value));
+      } catch (WebDriverException ex) {
+        // unrecognized platform, fallback to string
+      }
     }
   }
 

Diff for: java/client/test/org/openqa/selenium/remote/DesiredCapabilitiesTest.java

@@ -111,4 +111,14 @@ public void shouldNotAutomaticallyConvertPlatformIfItNotConvertible() {
     assertEquals(caps.getCapability(CapabilityType.PLATFORM), "FreeBSD");
   }
 
+  @Test
+  public void shouldNotAutomaticallyConvertPlatformIfItNotConvertibleInConstructor() {
+    Map<String, Object> capabilitiesMap = new HashMap<String, Object>() {{
+      put(CapabilityType.PLATFORM, "FreeBSD");
+    }};
+
+    DesiredCapabilities caps = new DesiredCapabilities(capabilitiesMap);
+    assertEquals(caps.getCapability(CapabilityType.PLATFORM), "FreeBSD");
+  }
+
 }