Properly handle absence of lo network interface.

jleyba · jleyba · commit 9779366828b2 · 2014-06-10T11:57:50.000-07:00
Fixes issue 7465.
diff --git a/javascript/node/selenium-webdriver/CHANGES.md b/javascript/node/selenium-webdriver/CHANGES.md
@@ -1,5 +1,6 @@
-## v2.43.0-dev
+## v2.42.1
 
+* FIXED: 7465: Fixed `net.getLoopbackAddress` on Windows
 * FIXED: 7277: Support `done` callback in Mocha's BDD interface
 * FIXED: 7156: `Promise#thenFinally` should not suppress original error
 
diff --git a/javascript/node/selenium-webdriver/net/index.js b/javascript/node/selenium-webdriver/net/index.js
@@ -41,7 +41,8 @@ function getAddress(loopback, opt_family) {
 
   var interfaces;
   if (loopback) {
-    interfaces = [getLoInterface()];
+    var lo = getLoInterface();
+    interfaces = lo ? [lo] : null;
   }
   interfaces = interfaces || os.networkInterfaces();
   for (var key in interfaces) {
diff --git a/javascript/node/selenium-webdriver/package.json b/javascript/node/selenium-webdriver/package.json
@@ -1,6 +1,6 @@
 {
     "name": "selenium-webdriver",
-    "version": "2.43.0-dev",
+    "version": "2.42.1",
     "description": "The official WebDriver JavaScript bindings from the Selenium project",
     "keywords": [
         "automation",

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,8 @@ function getAddress(loopback, opt_family) {`
`41`	`41`
`42`	`42`	`var interfaces;`
`43`	`43`	`if (loopback) {`
`44`		`- interfaces = [getLoInterface()];`
	`44`	`+ var lo = getLoInterface();`
	`45`	`+ interfaces = lo ? [lo] : null;`
`45`	`46`	`}`
`46`	`47`	`interfaces = interfaces \|\| os.networkInterfaces();`
`47`	`48`	`for (var key in interfaces) {`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "selenium-webdriver",`
`3`		`- "version": "2.43.0-dev",`
	`3`	`+ "version": "2.42.1",`
`4`	`4`	`"description": "The official WebDriver JavaScript bindings from the Selenium project",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"automation",`