Skip to content

Commit 996e551

Browse files
committed
Re-ignoring failing Java cookie tests for IE
Two of the three tests are also ignored for all major browsers. The third exposes an edge case in the new cookie handling, which is that it's not possible to get the "secure" flag for session cookies, only persisted cookies.
1 parent 84ac6da commit 996e551

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Diff for: java/client/test/org/openqa/selenium/CookieImplementationTest.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ public void testsShouldNotGetCookiesRelatedToCurrentDomainWithoutLeadingPeriod()
271271
assertCookieIsNotPresentWithName(cookieName);
272272
}
273273

274-
@Ignore({REMOTE,})
274+
@Ignore({REMOTE})
275275
@Test
276276
public void testShouldBeAbleToIncludeLeadingPeriodInDomainName() throws Exception {
277277
String cookieName = "name";
@@ -381,7 +381,7 @@ public void testRetainsCookieExpiry() {
381381
assertEquals(addedCookie.getExpiry(), retrieved.getExpiry());
382382
}
383383

384-
@Ignore(value = {PHANTOMJS, SAFARI})
384+
@Ignore(value = {IE, PHANTOMJS, SAFARI})
385385
@Test
386386
public void testRetainsCookieSecure() {
387387
driver.get(domainHelper.getSecureUrlForFirstValidHostname("animals"));
@@ -400,7 +400,7 @@ public void testRetainsCookieSecure() {
400400
assertTrue(retrieved.isSecure());
401401
}
402402

403-
@Ignore(value = {CHROME, FIREFOX, HTMLUNIT, PHANTOMJS, SAFARI})
403+
@Ignore(value = {CHROME, FIREFOX, IE, HTMLUNIT, PHANTOMJS, SAFARI})
404404
@Test
405405
public void testRetainsHttpOnlyFlag() {
406406
Cookie addedCookie =
@@ -447,7 +447,7 @@ public void testDeleteNotExistedCookie() {
447447
driver.manage().deleteCookieNamed(key);
448448
}
449449

450-
@Ignore(value = {CHROME, FIREFOX, PHANTOMJS, SAFARI})
450+
@Ignore(value = {CHROME, FIREFOX, IE, PHANTOMJS, SAFARI})
451451
@Test
452452
public void testShouldDeleteOneOfTheCookiesWithTheSameName() {
453453
driver.get(domainHelper.getUrlForFirstValidHostname("/common/animals"));

0 commit comments

Comments
 (0)