Skip to content

Commit a1d7320

Browse files
author
AutomatedTester
committed
Update FirefoxDriver to send both 'ELEMENT' and 'element-6066-11e4-a52e-4f735466cecf' when finding elements and returning elements
1 parent d5b792d commit a1d7320

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

javascript/firefox-driver/js/firefoxDriver.js

+8-7
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ FirefoxDriver.prototype.findElementInternal_ = function(respond, method,
462462

463463
if (element) {
464464
var id = Utils.addToKnownElements(element);
465-
respond.value = {'ELEMENT': id};
465+
respond.value = {'ELEMENT': id, 'element-6066-11e4-a52e-4f735466cecf': id};
466466
return respond.send();
467467
}
468468

@@ -550,7 +550,7 @@ FirefoxDriver.prototype.findElementsInternal_ = function(respond, method,
550550
for (var j = 0; j < elements.length; j++) {
551551
var element = elements[j];
552552
var elementId = Utils.addToKnownElements(element);
553-
elementIds.push({'ELEMENT': elementId});
553+
elementIds.push({'ELEMENT': elementId, 'element-6066-11e4-a52e-4f735466cecf': elementId});
554554
}
555555

556556
var wait = respond.session.getImplicitWait();
@@ -628,12 +628,13 @@ FirefoxDriver.prototype.switchToFrame = function(respond, parameters) {
628628
goog.log.info(FirefoxDriver.LOG_,
629629
'Switching to frame by index: ' + parameters.id);
630630
newWindow = bot.frame.findFrameByIndex(parameters.id, currentWindow);
631-
} else if (goog.isObject(parameters.id) && 'ELEMENT' in parameters.id) {
631+
} else if (goog.isObject(parameters.id) &&
632+
('ELEMENT' in parameters.id) || 'element-6066-11e4-a52e-4f735466cecf' in parameters.id) {
633+
var elId = parameters.id['element-6066-11e4-a52e-4f735466cecf'] ? parameters.id['element-6066-11e4-a52e-4f735466cecf'] : parameters.id['ELEMENT']
632634
goog.log.info(FirefoxDriver.LOG_,
633-
'Switching to frame by element: ' + parameters.id['ELEMENT']);
635+
'Switching to frame by element: ' + elId);
634636

635-
var element = Utils.getElementAt(parameters.id['ELEMENT'],
636-
currentWindow.document);
637+
var element = Utils.getElementAt(elId, currentWindow.document);
637638

638639
element = fxdriver.moz.unwrapFor4(element);
639640

@@ -680,7 +681,7 @@ FirefoxDriver.prototype.getActiveElement = function(respond) {
680681
var element = Utils.getActiveElement(respond.session.getDocument());
681682
var id = Utils.addToKnownElements(element);
682683

683-
respond.value = {'ELEMENT': id};
684+
respond.value = {'ELEMENT': id, 'element-6066-11e4-a52e-4f735466cecf': id};
684685
respond.send();
685686
};
686687

0 commit comments

Comments
 (0)