Skip to content

Commit bea9516

Browse files
author
AutomatedTester
committed
Output stdout/strerr to geckodriver.log instead of PIPE
Wires and Marionette can be super verbose with logging and just putting it to PIPE has unexpected performance issues.
1 parent 1f0ba93 commit bea9516

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ Generated/
5959
ipch/
6060
/iedriver.log
6161
/phantomjsdriver.log
62+
geckodriver.log
6263
.tags
6364
.ruby-version
6465
GPATH

py/selenium/webdriver/firefox/service.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,13 @@ def start(self):
5656
or when it can't connect to the service
5757
"""
5858
env = self.env or os.environ
59+
self.log_file = file("geckodriver.log", "w")
5960
try:
6061
#import pdb; pdb.set_trace()
6162
self.process = subprocess.Popen([
6263
self.path,
6364
"-b", self.firefox_binary, '--webdriver-port', "%d" % self.port],
64-
env=env, stdout=PIPE)
65+
env=env, stdout=self.log_file, stderr=self.log_file)
6566
except Exception as e:
6667
raise WebDriverException(
6768
"'" + os.path.basename(self.path) + "' executable needs to be \

0 commit comments

Comments
 (0)