Skip to content

Commit c7c6c4a

Browse files
joshbruningsevaseva
authored andcommitted
Update test for Chrome 44 stable release.
The previous behavior was true for a release from the beta channel, but the bug was reported and fixed. Signed-off-by: Seva Lotoshnikov <[email protected]>
1 parent 1431a26 commit c7c6c4a

File tree

1 file changed

+11
-23
lines changed

1 file changed

+11
-23
lines changed

javascript/atoms/test/select_test.html

+11-23
Original file line numberDiff line numberDiff line change
@@ -275,12 +275,7 @@
275275
expectChanges(radioButtons[0]);
276276

277277
action(radioButtons[0]);
278-
279-
// Chromium 44 seems to have a regression here:
280-
// https://code.google.com/p/chromium/issues/detail?id=500084
281-
if (!goog.userAgent.product.CHROME || !bot.userAgent.isProductVersion(44)) {
282-
assertChanges(0);
283-
}
278+
assertChanges(0);
284279
assertTrue(bot.dom.isSelected(radioButtons[0]));
285280
}
286281

@@ -365,17 +360,10 @@
365360

366361
action(elem);
367362

368-
// WebKit (except Chromium 44+) and IE9 standards mode fire change events when the
363+
// WebKit and IE9 standards mode fire change events when the
369364
// checkbox isn't toggled.
370-
// TODO: Check if Chromium behavior changes after this issue is resolved:
371-
// https://code.google.com/p/chromium/issues/detail?id=500084
372-
if (bot.userAgent.IE_DOC_9 ||
373-
(goog.userAgent.WEBKIT &&
374-
!(goog.userAgent.product.CHROME && bot.userAgent.isProductVersion(44)))) {
375-
assertChanges(1);
376-
} else {
377-
assertChanges(0);
378-
}
365+
assertChanges(
366+
goog.userAgent.WEBKIT || bot.userAgent.IE_DOC_9 ? 1 : 0);
379367
assertFalse(bot.dom.isSelected(elem));
380368
}
381369

@@ -398,16 +386,16 @@
398386

399387
action(elem);
400388

401-
// WebKit selects a radio button even when the handler prevents the default; others do not.
402-
if (goog.userAgent.WEBKIT && !goog.userAgent.product.CHROME) {
389+
// Chrome < 39 and WebKit select a radio button even when the handler
390+
// prevents the default; IE does not.
391+
if ((goog.userAgent.product.CHROME &&
392+
!bot.userAgent.isProductVersion(39)) ||
393+
(goog.userAgent.WEBKIT && !goog.userAgent.product.CHROME)) {
403394
assertChanges(1);
404395
assertTrue(bot.dom.isSelected(elem));
405396
} else {
406-
// IE9 standards mode, Chromium 43 and earlier versions still fire the change event.
407-
// TODO: Check if Chromium behavior changes after this issue is resolved:
408-
// https://code.google.com/p/chromium/issues/detail?id=500084
409-
if (bot.userAgent.IE_DOC_9 ||
410-
goog.userAgent.product.CHROME && !bot.userAgent.isProductVersion(44)) {
397+
// IE9 standards mode and Chrome still fire the change event.
398+
if (bot.userAgent.IE_DOC_9 || goog.userAgent.product.CHROME) {
411399
assertChanges(1);
412400
} else {
413401
assertChanges(0);

0 commit comments

Comments
 (0)