Skip to content

Commit d0958a6

Browse files
committed
server: Making a copy of capabilities object to prevent its modification if a user registers a custom driver provider with his own capabilities
1 parent 26bf0bc commit d0958a6

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

java/server/src/org/openqa/selenium/remote/server/DefaultDriverProvider.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import org.openqa.selenium.Capabilities;
2020
import org.openqa.selenium.WebDriver;
2121
import org.openqa.selenium.WebDriverException;
22+
import org.openqa.selenium.remote.DesiredCapabilities;
2223

2324
import java.lang.reflect.Constructor;
2425
import java.lang.reflect.InvocationTargetException;
@@ -38,12 +39,12 @@ public class DefaultDriverProvider implements DriverProvider {
3839
private String driverClassName;
3940

4041
public DefaultDriverProvider(Capabilities capabilities, Class<? extends WebDriver> driverClass) {
41-
this.capabilities = capabilities;
42+
this.capabilities = new DesiredCapabilities(capabilities);
4243
this.driverClass = driverClass;
4344
}
4445

4546
public DefaultDriverProvider(Capabilities capabilities, String driverClassName) {
46-
this.capabilities = capabilities;
47+
this.capabilities = new DesiredCapabilities(capabilities);
4748
this.driverClassName = driverClassName;
4849
}
4950

0 commit comments

Comments
 (0)