Skip to content

Commit d23f680

Browse files
committed
OnBehalf of 'sun void': make it so ResourceWarning isn't generated at all
Fixes google code issue 5923
1 parent 60f377d commit d23f680

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

Diff for: py/selenium/webdriver/common/utils.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,12 @@ def is_connectable(port):
4545
socket_ = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
4646
socket_.settimeout(1)
4747
socket_.connect(("127.0.0.1", port))
48-
socket_.close()
49-
return True
48+
result = True
5049
except socket.error:
51-
return False
50+
result = False
51+
finally:
52+
socket_.close()
53+
return result
5254

5355
def is_url_connectable(port):
5456
"""

0 commit comments

Comments
 (0)