Skip to content

Commit d53e906

Browse files
committed
Fix ie_driver tests to assert that isInParentOverflow returns a particular value. It doesn't return a boolean, so passing it directly to assertTrue/assertFalse was an error.
On behalf of juangj.
1 parent b1a6a33 commit d53e906

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

Diff for: javascript/ie-driver/test/parent_overflow_test.html

+5-4
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<title>parent_overflow_test.html</title>
55
<script src="test_bootstrap.js"></script>
66
<script type="text/javascript">
7+
goog.require('bot.dom.OverflowState');
78
goog.require('bot.locators');
89
goog.require('goog.testing.jsunit');
910
goog.require('webdriver.ie');
@@ -18,15 +19,15 @@
1819

1920
function testScrollElementInToView() {
2021
var element = bot.locators.findElement({ id: 'line8' });
21-
assertTrue(webdriver.ie.isInParentOverflow(element));
22+
assertEquals(bot.dom.OverflowState.SCROLL, webdriver.ie.isInParentOverflow(element));
2223
element.scrollIntoView(false);
23-
assertFalse(webdriver.ie.isInParentOverflow(element));
24+
assertEquals(bot.dom.OverflowState.NONE, webdriver.ie.isInParentOverflow(element));
2425

2526
// Verify scroll is correct for up and to the left.
2627
var element = bot.locators.findElement({ id: 'line1' });
27-
assertTrue(webdriver.ie.isInParentOverflow(element));
28+
assertEquals(bot.dom.OverflowState.SCROLL, webdriver.ie.isInParentOverflow(element));
2829
element.scrollIntoView(false);
29-
assertFalse(webdriver.ie.isInParentOverflow(element));
30+
assertEquals(bot.dom.OverflowState.NONE, webdriver.ie.isInParentOverflow(element));
3031
}
3132
</script>
3233
<div style="height: 150px"></div>

0 commit comments

Comments
 (0)