js: Expose Closure's logging system through the webdriver.logging module.

This creates a disconnect between local and remote logging
(e.g. driver.manage().logs().get('browser')), but that same disconnect exists
in the other language bindings too. I'm punting on defining a consistent API
until the W3C spec defines logging behavior.

Author: jleyba

Diff for: javascript/node/selenium-webdriver/CHANGES.md

@@ -1,5 +1,7 @@
 ## v2.46.0-dev
 
+* Exposed a new logging API via the `webdriver.logging` module. For usage, see
+    `example/logging.js`.
 * Added support for using a proxy server for WebDriver commands.
     See `Builder#usingWebDriverProxy()` for more info.
 * Removed deprecated functions:

Diff for: javascript/node/selenium-webdriver/example/logging.js

@@ -0,0 +1,39 @@
+// Licensed to the Software Freedom Conservancy (SFC) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The SFC licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+/**
+ * @fileoverview Demonstrates how to use WebDriver's logging sysem.
+ */
+
+'use strict';
+
+var webdriver = require('..'),
+    By = webdriver.By,
+    until = webdriver.until;
+
+webdriver.logging.installConsoleHandler();
+webdriver.logging.getLogger().setLevel(webdriver.logging.Level.ALL);
+
+var driver = new webdriver.Builder()
+    .forBrowser('firefox')
+    .build();
+
+driver.get('http://www.google.com/ncr');
+driver.findElement(By.name('q')).sendKeys('webdriver');
+driver.findElement(By.name('btnG')).click();
+driver.wait(until.titleIs('webdriver - Google Search'), 1000);
+driver.quit();

Diff for: javascript/node/selenium-webdriver/test/_base_test.js

@@ -61,7 +61,11 @@ function runClosureTest(file) {
   describe(name, function() {
     var context = new base.Context(true);
     context.closure.document.title = name;
-    if (process.env.VERBOSE != '1') {
+    if (process.env.VERBOSE == '1') {
+      context.closure.goog.require('webdriver.logging');
+      context.closure.goog.module.get('webdriver.logging')
+          .installConsoleHandler();
+    } else {
       // Null out console so everything loads silently.
       context.closure.console = null;
     }
@@ -89,7 +93,8 @@ function runClosureTest(file) {
           }
           var results = tc.getTestResults();
           done(Error('\n' + Object.keys(results).map(function(name) {
-            var msg = [name + ': ' + (results[name].length ? 'FAILED' : 'PASSED')];
+            var msg =
+                [name + ': ' + (results[name].length ? 'FAILED' : 'PASSED')];
             if (results[name].length) {
               msg = msg.concat(results[name]);
             }

Diff for: javascript/webdriver/http/http.js

@@ -30,6 +30,7 @@ goog.require('goog.array');
 goog.require('goog.json');
 goog.require('webdriver.CommandExecutor');
 goog.require('webdriver.CommandName');
+goog.require('webdriver.logging');
 goog.require('webdriver.promise');
 
 
@@ -78,6 +79,11 @@ webdriver.http.Executor = function(client) {
    * @private {!Object<{method:string, path:string}>}
    */
   this.customCommands_ = {};
+
+  /**
+   * @private {!webdriver.logging.Logger}
+   */
+  this.log_ = webdriver.logging.getLogger('webdriver.http.Executor');
 };
 
 
@@ -113,13 +119,22 @@ webdriver.http.Executor.prototype.execute = function(command, callback) {
   var path = webdriver.http.Executor.buildPath_(resource.path, parameters);
   var request = new webdriver.http.Request(resource.method, path, parameters);
 
+  var log = this.log_;
+  log.finer(function() {
+    return '>>>\n' + request;
+  });
+
   this.client_.send(request, function(e, response) {
     var responseObj;
     if (!e) {
+      log.finer(function() {
+        return '<<<\n' + response;
+      });
       try {
         responseObj = webdriver.http.Executor.parseHttpResponse_(
             /** @type {!webdriver.http.Response} */ (response));
       } catch (ex) {
+        log.warning('Error parsing response', ex);
         e = ex;
       }
     }