Ruby: make sure the alert text is included in UnhandledAlertErrors

Author: jarib

rake-tasks/crazy_fun/mappings/ruby.rb

@@ -105,7 +105,7 @@ def handle(fun, dir, args)
         ruby :include => args[:include],
              :require => args[:require],
              :command => args[:command],
-             :args    => %w[--format CI::Reporter::RSpec --format s --color] + (!!ENV['example'] ? ['--example', ENV['example']] : []),
+             :args    => %w[--format CI::Reporter::RSpec --format doc --color] + (!!ENV['example'] ? ['--example', ENV['example']] : []),
              :debug   => !!ENV['log'],
              :files   => args[:srcs]
       end

rb/CHANGES

@@ -1,6 +1,7 @@
 2.43.0 (???)
 ============
 
+* Make sure UnhandledAlertErrors includes the alert text if provided by the driver.
 * Firefox
   - Make sure browser process is properly killed if silent startup hangs (#7392)
 

rb/lib/selenium/webdriver/remote/response.rb

@@ -31,6 +31,7 @@ def error_message
           case val
           when Hash
             msg = val['message'] or return "unknown error"
+            msg << ": #{val['alert']['text'].inspect}" if val['alert'].kind_of?(Hash) && val['alert']['text']
             msg << " (#{ val['class'] })" if val['class']
           when String
             msg = val

rb/spec/integration/selenium/webdriver/target_locator_spec.rb

@@ -175,7 +175,7 @@
         driver.find_element(:id => "alert").click
         wait_for_alert
 
-        lambda { driver.title }.should raise_error(Selenium::WebDriver::Error::UnhandledAlertError)
+        lambda { driver.title }.should raise_error(Selenium::WebDriver::Error::UnhandledAlertError, /: "cheese"/)
 
         driver.title.should == "Testing Alerts" # :chrome does not auto-dismiss the alert
       end