Fixing cookie parsing error in .NET bindings

jimevans · jimevans · commit df012b8f8a8e · 2015-07-01T11:58:45.000-04:00
The JSON response for cookie expiration date is a number, not an integer.
The .NET bindings were not handling the fact that a floating point number
could be included in the JSON object as an expiration time.
diff --git a/dotnet/src/webdriver/Cookie.cs b/dotnet/src/webdriver/Cookie.cs
@@ -239,8 +239,8 @@ public static Cookie FromDictionary(Dictionary<string, object> rawCookie)
             DateTime? expires = null;
             if (rawCookie.ContainsKey("expiry") && rawCookie["expiry"] != null)
             {
-                long seconds = 0;
-                if (long.TryParse(rawCookie["expiry"].ToString(), out seconds))
+                double seconds = 0;
+                if (double.TryParse(rawCookie["expiry"].ToString(), NumberStyles.Number, CultureInfo.InvariantCulture,  out seconds))
                 {
                     try
                     {

Original file line number	Diff line number	Diff line change
`@@ -239,8 +239,8 @@ public static Cookie FromDictionary(Dictionary<string, object> rawCookie)`
`239`	`239`	`DateTime? expires = null;`
`240`	`240`	`if (rawCookie.ContainsKey("expiry") && rawCookie["expiry"] != null)`
`241`	`241`	`{`
`242`		`- long seconds = 0;`
`243`		`- if (long.TryParse(rawCookie["expiry"].ToString(), out seconds))`
	`242`	`+ double seconds = 0;`
	`243`	`+ if (double.TryParse(rawCookie["expiry"].ToString(), NumberStyles.Number, CultureInfo.InvariantCulture, out seconds))`
`244`	`244`	`{`
`245`	`245`	`try`
`246`	`246`	`{`