Skip to content

Commit f16fbae

Browse files
rbribarancev
authored andcommitted
HtmlUnit: reduce the visibility of some methods as announced two years before
Signed-off-by: Alexei Barantsev <[email protected]>
1 parent f548be9 commit f16fbae

File tree

2 files changed

+28
-39
lines changed

2 files changed

+28
-39
lines changed

Diff for: java/client/src/org/openqa/selenium/htmlunit/HtmlUnitKeyboard.java

+1-4
Original file line numberDiff line numberDiff line change
@@ -120,10 +120,7 @@ public void releaseKey(CharSequence keyToRelease) {
120120
htmlElement.sendKeyUpEvent(keyToRelease);
121121
}
122122

123-
/**
124-
* @deprecated Visibility will soon be reduced.
125-
*/
126-
public void performSingleKeyAction(HtmlElement element, CharSequence modifierKey, String eventDescription) {
123+
void performSingleKeyAction(HtmlElement element, CharSequence modifierKey, String eventDescription) {
127124
boolean shiftKey = modifierKey.equals(Keys.SHIFT);
128125
boolean ctrlKey = modifierKey.equals(Keys.CONTROL);
129126
boolean altKey = modifierKey.equals(Keys.ALT);

Diff for: java/client/src/org/openqa/selenium/htmlunit/HtmlUnitWebElement.java

+27-35
Original file line numberDiff line numberDiff line change
@@ -18,27 +18,12 @@
1818

1919
package org.openqa.selenium.htmlunit;
2020

21-
import com.google.common.base.Strings;
22-
import com.google.common.base.Throwables;
23-
24-
import com.gargoylesoftware.htmlunit.ScriptResult;
25-
import com.gargoylesoftware.htmlunit.html.DomElement;
26-
import com.gargoylesoftware.htmlunit.html.DomNode;
27-
import com.gargoylesoftware.htmlunit.html.DomText;
28-
import com.gargoylesoftware.htmlunit.html.HtmlButton;
29-
import com.gargoylesoftware.htmlunit.html.HtmlElement;
30-
import com.gargoylesoftware.htmlunit.html.HtmlForm;
31-
import com.gargoylesoftware.htmlunit.html.HtmlImageInput;
32-
import com.gargoylesoftware.htmlunit.html.HtmlInput;
33-
import com.gargoylesoftware.htmlunit.html.HtmlLabel;
34-
import com.gargoylesoftware.htmlunit.html.HtmlOption;
35-
import com.gargoylesoftware.htmlunit.html.HtmlPage;
36-
import com.gargoylesoftware.htmlunit.html.HtmlPreformattedText;
37-
import com.gargoylesoftware.htmlunit.html.HtmlScript;
38-
import com.gargoylesoftware.htmlunit.html.HtmlSelect;
39-
import com.gargoylesoftware.htmlunit.html.HtmlSubmitInput;
40-
import com.gargoylesoftware.htmlunit.html.HtmlTextArea;
41-
import com.gargoylesoftware.htmlunit.javascript.host.Event;
21+
import java.io.IOException;
22+
import java.net.MalformedURLException;
23+
import java.util.ArrayList;
24+
import java.util.LinkedList;
25+
import java.util.List;
26+
import java.util.concurrent.Callable;
4227

4328
import net.sourceforge.htmlunit.corejs.javascript.Undefined;
4429

@@ -65,12 +50,25 @@
6550
import org.w3c.dom.Attr;
6651
import org.w3c.dom.NamedNodeMap;
6752

68-
import java.io.IOException;
69-
import java.net.MalformedURLException;
70-
import java.util.ArrayList;
71-
import java.util.LinkedList;
72-
import java.util.List;
73-
import java.util.concurrent.Callable;
53+
import com.gargoylesoftware.htmlunit.ScriptResult;
54+
import com.gargoylesoftware.htmlunit.html.DomNode;
55+
import com.gargoylesoftware.htmlunit.html.DomText;
56+
import com.gargoylesoftware.htmlunit.html.HtmlButton;
57+
import com.gargoylesoftware.htmlunit.html.HtmlElement;
58+
import com.gargoylesoftware.htmlunit.html.HtmlForm;
59+
import com.gargoylesoftware.htmlunit.html.HtmlImageInput;
60+
import com.gargoylesoftware.htmlunit.html.HtmlInput;
61+
import com.gargoylesoftware.htmlunit.html.HtmlLabel;
62+
import com.gargoylesoftware.htmlunit.html.HtmlOption;
63+
import com.gargoylesoftware.htmlunit.html.HtmlPage;
64+
import com.gargoylesoftware.htmlunit.html.HtmlPreformattedText;
65+
import com.gargoylesoftware.htmlunit.html.HtmlScript;
66+
import com.gargoylesoftware.htmlunit.html.HtmlSelect;
67+
import com.gargoylesoftware.htmlunit.html.HtmlSubmitInput;
68+
import com.gargoylesoftware.htmlunit.html.HtmlTextArea;
69+
import com.gargoylesoftware.htmlunit.javascript.host.Event;
70+
import com.google.common.base.Strings;
71+
import com.google.common.base.Throwables;
7472

7573

7674
public class HtmlUnitWebElement implements WrapsDriver,
@@ -306,17 +304,11 @@ private void switchFocusToThisIfNeeded() {
306304
element.focus();
307305
}
308306

309-
/**
310-
* @deprecated Visibility will soon be reduced.
311-
*/
312-
public void sendKeyDownEvent(CharSequence modifierKey) {
307+
void sendKeyDownEvent(CharSequence modifierKey) {
313308
sendSingleKeyEvent(modifierKey, Event.TYPE_KEY_DOWN);
314309
}
315310

316-
/**
317-
* @deprecated Visibility will soon be reduced.
318-
*/
319-
public void sendKeyUpEvent(CharSequence modifierKey) {
311+
void sendKeyUpEvent(CharSequence modifierKey) {
320312
sendSingleKeyEvent(modifierKey, Event.TYPE_KEY_UP);
321313
}
322314

0 commit comments

Comments
 (0)