Skip to content

Commit f1cfd59

Browse files
committed
Don't augment for TakesScreenshot which RemoteWebDriver already implements.
A follow up to 4555973
1 parent 67c6cf8 commit f1cfd59

File tree

3 files changed

+6
-59
lines changed

3 files changed

+6
-59
lines changed

Diff for: java/client/src/org/openqa/selenium/remote/AddTakesScreenshot.java

-50
This file was deleted.

Diff for: java/client/src/org/openqa/selenium/remote/BaseAugmenter.java

+6-8
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import static org.openqa.selenium.remote.CapabilityType.SUPPORTS_LOCATION_CONTEXT;
2424
import static org.openqa.selenium.remote.CapabilityType.SUPPORTS_NETWORK_CONNECTION;
2525
import static org.openqa.selenium.remote.CapabilityType.SUPPORTS_WEB_STORAGE;
26-
import static org.openqa.selenium.remote.CapabilityType.TAKES_SCREENSHOT;
2726

2827
import com.google.common.collect.Maps;
2928

@@ -49,7 +48,6 @@ public abstract class BaseAugmenter {
4948

5049
public BaseAugmenter() {
5150
addDriverAugmentation(SUPPORTS_FINDING_BY_CSS, new AddFindsByCss());
52-
addDriverAugmentation(TAKES_SCREENSHOT, new AddTakesScreenshot());
5351
addDriverAugmentation(SUPPORTS_LOCATION_CONTEXT, new AddLocationContext());
5452
addDriverAugmentation(SUPPORTS_APPLICATION_CACHE, new AddApplicationCache());
5553
addDriverAugmentation(SUPPORTS_NETWORK_CONNECTION, new AddNetworkConnection());
@@ -63,12 +61,12 @@ public BaseAugmenter() {
6361
/**
6462
* Add a mapping between a capability name and the implementation of the interface that name
6563
* represents for instances of {@link org.openqa.selenium.WebDriver}. For example (@link
66-
* CapabilityType#TAKES_SCREENSHOT} is represents the interface
67-
* {@link org.openqa.selenium.TakesScreenshot}, which is implemented via the
68-
* {@link org.openqa.selenium.remote.AddTakesScreenshot} provider.
69-
*
64+
* CapabilityType#SUPPORTS_FINDING_BY_CSS} represents the interface
65+
* {@link org.openqa.selenium.internal.FindsByCssSelector}, which is implemented via the
66+
* {@link org.openqa.selenium.remote.AddFindsByCss} provider.
67+
*
7068
* Note: This method is still experimental. Use at your own risk.
71-
*
69+
*
7270
* @param capabilityName The name of the capability to model
7371
* @param handlerClass The provider of the interface and implementation
7472
*/
@@ -79,7 +77,7 @@ public void addDriverAugmentation(String capabilityName, AugmenterProvider handl
7977
/**
8078
* Add a mapping between a capability name and the implementation of the interface that name
8179
* represents for instances of {@link org.openqa.selenium.WebElement}. For example (@link
82-
* CapabilityType#TAKES_SCREENSHOT} is represents the interface
80+
* CapabilityType#SUPPORTS_FINDING_BY_CSS} represents the interface
8381
* {@link org.openqa.selenium.internal.FindsByCssSelector}, which is implemented via the
8482
* {@link AddFindsByCss} provider.
8583
*

Diff for: java/client/src/org/openqa/selenium/remote/build.desc

-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ java_library(name = "augmenter",
5050
"AddFindsChildByCss.java",
5151
"AddRemoteTouchScreen.java",
5252
"AddRotatable.java",
53-
"AddTakesScreenshot.java",
5453
"Augmenter.java",
5554
"AugmenterProvider.java",
5655
"BaseAugmenter.java",

0 commit comments

Comments
 (0)