Reverted breaking API change

Cannot remove IDisposable from MSSqlServerAuditSink class without bumping major version, so we leave it the same.

Author: ckadluba

src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/MSSqlServerAuditSink.cs

@@ -26,7 +26,7 @@ namespace Serilog.Sinks.MSSqlServer
     /// Writes log events as rows in a table of MSSqlServer database using Audit logic, meaning that each row is synchronously committed
     /// and any errors that occur are propagated to the caller.
     /// </summary>
-    public class MSSqlServerAuditSink : ILogEventSink
+    public class MSSqlServerAuditSink : ILogEventSink, IDisposable
     {
         private readonly ISqlLogEventWriter _sqlLogEventWriter;
 
@@ -97,6 +97,25 @@ internal MSSqlServerAuditSink(
         public void Emit(LogEvent logEvent) =>
             _sqlLogEventWriter.WriteEvent(logEvent);
 
+        /// <summary>
+        /// Performs application-defined tasks associated with freeing, releasing, or resetting unmanaged resources.
+        /// </summary>
+        public void Dispose()
+        {
+            Dispose(true);
+            GC.SuppressFinalize(this);
+        }
+
+        /// <summary>
+        /// Releases the unmanaged resources used by the Serilog.Sinks.MSSqlServer.MSSqlServerAuditSink and optionally
+        /// releases the managed resources.
+        /// </summary>
+        /// <param name="disposing">True to release both managed and unmanaged resources; false to release only unmanaged resources.</param>
+        protected virtual void Dispose(bool disposing)
+        {
+            // This class needn't to dispose anything. This is just here for sink interface compatibility.
+        }
+
         private static void ValidateParameters(MSSqlServerSinkOptions sinkOptions, ColumnOptions columnOptions)
         {
             if (sinkOptions?.TableName == null)

test/Serilog.Sinks.MSSqlServer.Tests/Sinks/MSSqlServer/MSSqlServerAuditSinkTests.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Data;
 using Moq;
 using Serilog.Events;
 using Serilog.Parsing;
@@ -11,7 +12,7 @@
 namespace Serilog.Sinks.MSSqlServer.Tests
 {
     [Trait(TestCategory.TraitName, TestCategory.Unit)]
-    public class MSSqlServerAuditSinkTests
+    public class MSSqlServerAuditSinkTests : IDisposable
     {
         private readonly MSSqlServerSinkOptions _sinkOptions;
         private readonly Serilog.Sinks.MSSqlServer.ColumnOptions _columnOptions;
@@ -22,6 +23,7 @@ public class MSSqlServerAuditSinkTests
         private readonly string _tableName = "tableName";
         private readonly string _schemaName = "schemaName";
         private MSSqlServerAuditSink _sut;
+        private bool _disposedValue;
 
         public MSSqlServerAuditSinkTests()
         {
@@ -161,5 +163,20 @@ private void SetupSut(bool autoCreateSqlDatabase = false, bool autoCreateSqlTabl
             _sinkOptions.AutoCreateSqlTable = autoCreateSqlTable;
             _sut = new MSSqlServerAuditSink(_sinkOptions, _columnOptions, _sinkDependencies);
         }
+
+        protected virtual void Dispose(bool disposing)
+        {
+            if (!_disposedValue)
+            {
+                _sut?.Dispose();
+                _disposedValue = true;
+            }
+        }
+
+        public void Dispose()
+        {
+            Dispose(disposing: true);
+            GC.SuppressFinalize(this);
+        }
     }
 }