Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

RFC: Support getStaticPaths fallback: 'blocking' #833

Closed
strozw opened this issue Dec 4, 2020 · 4 comments · Fixed by #1007
Closed

RFC: Support getStaticPaths fallback: 'blocking' #833

strozw opened this issue Dec 4, 2020 · 4 comments · Fixed by #1007
Labels
enhancement New feature or request

Comments

@strozw
Copy link

strozw commented Dec 4, 2020

Is your feature request related to a problem? Please describe.

next.js 10 add support fallback blocking.
https://nextjs.org/blog/next-10#blocking-fallback-for-getstaticpaths

This feature is useful for SEO & OGP support.

Describe the solution you'd like

I want html response like existing ssg fallback.

Describe alternatives you've considered

We are considering whether to support it with SSR.
However, from a performance standpoint, I plan to give up OGP support and use SSG fallback for the time being.

Additional context

I'm trying this feature in following repository.
https://github.com/strozw/sample-serverless-nextjs

@arelaxend
Copy link

arelaxend commented Dec 20, 2020

@dphang
Copy link
Collaborator

dphang commented Dec 22, 2020

@arelaxend sorry I haven't had as much time this month but if you want to work on it, I'd be happy to review the PR. If not I can probably work on it once I have more time (maybe end of month or next month). Though fallback logic is a bit interesting since we are using origin request + origin response handler (actually we were thinking of trying to simplify to one handler).

For blocking fallback, I think we should check if fallback:blocking is enabled in origin request handler and render + save the response in S3, then return it.

@sinuheshinbr
Copy link

The implementation of this feature would be much appreciated!

@dphang dphang added the enhancement New feature or request label Jan 19, 2021
@evangow
Copy link

evangow commented Feb 20, 2021

@dphang I wrote some pseudocode to address { fallback: "blocking } along with setting a revalidation parameter in the issue here #804 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants