Skip to content

Commit 12f7ae3

Browse files
Didier SENMARTINPsycholive
Didier SENMARTIN
authored andcommitted
Code review
1 parent 94d71a1 commit 12f7ae3

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -431,13 +431,13 @@ functions:
431431
### Copy dependencies instead of linking
432432

433433
Before final packaging, a link is created in .serverless folder for python dependencies.
434-
If it is not possible to create a symbolic link, dependencies can be copied instead of linked
435-
whith the foloowing option:
434+
If it is not possible for the OS to create a symbolic link, dependencies can be copied,
435+
instead of linked, with the following option:
436436

437437
```yaml
438438
custom:
439439
pythonRequirements:
440-
useFinalCopy: true
440+
useSymlinks: false
441441
```
442442

443443
## Manual invocations

index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class ServerlessPythonRequirements {
5858
pipCmdExtraArgs: [],
5959
noDeploy: [],
6060
vendor: '',
61-
useFinalCopy: false,
61+
useSymlinks: true,
6262
},
6363
(this.serverless.service.custom &&
6464
this.serverless.service.custom.pythonRequirements) ||

lib/pip.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -782,7 +782,7 @@ async function installAllRequirements() {
782782
reqsInstalledAt != symlinkPath
783783
) {
784784
// Windows can't symlink so we have to use junction on Windows
785-
if (this.serverless.service.custom.pythonRequirements.useFinalCopy) {
785+
if (!this.serverless.service.custom.pythonRequirements.useSymlinks) {
786786
fse.copySync(reqsInstalledAt, symlinkPath);
787787
} else if (process.platform == 'win32') {
788788
fse.symlink(reqsInstalledAt, symlinkPath, 'junction');

0 commit comments

Comments
 (0)