Skip to content

Individual requirements should allow pipenv/poetry for functions #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michael-c-hoffman opened this issue Dec 11, 2020 · 4 comments
Open

Comments

@michael-c-hoffman
Copy link

When using package individually, the requirements are not pulled from a Pipfile/peotry file if present, only requirements.txt
(this is a completely different behaviour than when not using package individually as at the root of the project on can use Pipfile/poetry)

If there is a Pipfile/poetry file at the root when using package individually the root level requirements are only packaged not the root+function or just function requirements.

I would like to continue to use Pipfile at the root level as this contains development packages for pytest and other frameworks. I would then like to include a Pipfile in each function that needs to be package with that function's requirements. Currently if serverless-python-requirements detects a Pipfile at the root all other function requirements are ignored.

@antoinechamot
Copy link

same here with:
package:
individually: true

if i have a Pipfile in my module it is just ignored

@bsamuel-ui bsamuel-ui changed the title individual requirements allow pipenv/peotry for functions Individual requirements should allow pipenv/poetry for functions Apr 11, 2021
@bsamuel-ui
Copy link
Contributor

What would you expect the layout to look like? For instance:

serverless.yml
module1/
    pyproject.toml
    func1/
        __init__.py
module2/
    Pipfile
    func2/
        __init__.py

@michael-c-hoffman
Copy link
Author

yes, that would be the expected layout

@gerbenoostra
Copy link

I also expected to have pyproject.toml & requirements.txt to behave similar: if there's a pyproject.toml in the module directory, it would be used as preprocessing step to create the requirements.txt in the module dir.

However, only a pyproject.toml in the root folder results in creating a requirements.txt (in the root folder)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants