Skip to content

Solving definitions issues #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fredericbarthelet opened this issue Nov 15, 2020 · 3 comments · May be fixed by #12
Open

Solving definitions issues #1

fredericbarthelet opened this issue Nov 15, 2020 · 3 comments · May be fixed by #12
Assignees

Comments

@fredericbarthelet
Copy link
Contributor

Solving issues listed in https://github.com/serverless/typescript/README.md with solution for discontinued maintenance of json-schema-to-typescript -> bcherny/json-schema-to-typescript#347

@fredericbarthelet
Copy link
Contributor Author

Switching to quicktype ?
-> https://github.com/quicktype/quicktype
-> https://dev.to/okeeffed/generating-types-from-json-schema-with-quicktype-1fh2

@fredericbarthelet
Copy link
Contributor Author

Issue on custom property not accepting additional properties : glideapps/quicktype#1615

@spawn-guy
Copy link

it seems that s3 event definition is not correctly converted

https://github.com/serverless/typescript/blob/master/index.d.ts#L164

should be

            s3:
              | string
              | {
                  bucket: string | AwsCfFunction;
                  event?: string;
                  existing?: boolean;
                  rules?: {
                    suffix?: string;
                  }[] | {
                      prefix?: string;
                  }[];
                };
          }

as AJV schema wants only 1 property
Configuration warning at 'functions.lambda_name.events[0].s3.rules[0]': should NOT have more than 1 properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants