Skip to content

Move the url::quirks module to Servo #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SimonSapin opened this issue Oct 17, 2018 · 3 comments
Closed

Move the url::quirks module to Servo #460

SimonSapin opened this issue Oct 17, 2018 · 3 comments
Labels
breaking-change

Comments

@SimonSapin
Copy link
Member

Servo’s components/script/dom/urlhelper.rs is likely its only user, it’s somewhat out of place in rust-url.

Can all of url::quirks be reproduced with only the public APIs of url?
@SimonSapin SimonSapin mentioned this issue Oct 17, 2018
Closed
42 tasks
@SimonSapin
Copy link
Member Author

Can all of url::quirks be reproduced with only the public APIs of url?

The answer to that one is: no.

@lucacasonato
Copy link
Collaborator

Deno and rust-urlpattern both use the quirks module too. It would be great to keep this in the url crate.

@valenting
Copy link
Collaborator

Thanks for the info. Seems like we should keep it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SimonSapin @valenting @lucacasonato