Skip to content

Create non-pluggin version of the library #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pngcsgta opened this issue Jan 17, 2022 · 2 comments · Fixed by #153 or #155
Closed

Create non-pluggin version of the library #152

pngcsgta opened this issue Jan 17, 2022 · 2 comments · Fixed by #153 or #155
Labels
enhancement New feature or request

Comments

@pngcsgta
Copy link
Contributor

I would like to have the possibilities to import the library as a component or registering the component. Usage example:

As a component:

import VueEllipseProgress from "vue-elpispis"

Vue.extend({
   name: "OterComp",
    components : {
        VueEllipseProgress,
    },
})

Registering the component:

import VueEllipseProgress from "vue-elpispis"
Vue.component('elipsisComponent', VueEllipseProgress);
@setaman
Copy link
Owner

setaman commented Jan 17, 2022

@pngcsgta Hi,

i assume you are using version 1.x. In version 2 it's already implemented. I'm currently considering to release a v2.x compatible with both Vue 2 and 3. So all features would be available for all users. But that would take some time to evaluate this decision.

On the other hand it would be a small change in plugin.js. Maybe you might to submit a PR?

@pngcsgta
Copy link
Contributor Author

PR here: #153

@setaman setaman linked a pull request Jan 17, 2022 that will close this issue
5 tasks
@setaman setaman added the enhancement New feature or request label Jan 18, 2022
@setaman setaman mentioned this issue Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants