Skip to content

Add optional ploidy flag to HWE test function #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eric-czech opened this issue Aug 31, 2020 · 0 comments · Fixed by #334
Closed

Add optional ploidy flag to HWE test function #221

eric-czech opened this issue Aug 31, 2020 · 0 comments · Fixed by #334
Labels
core operations Issues related to domain-specific functionality such as LD pruning, PCA, association testing, etc.

Comments

@eric-czech
Copy link
Collaborator

If you don't have an array with a ploidy dimension, the current function will throw an error. It shouldn't require an array just to check that the ploidy in the genotype data is diploid and adding a dummy array as a workaround is not a good UX.
@hammer hammer added the core operations Issues related to domain-specific functionality such as LD pruning, PCA, association testing, etc. label Sep 1, 2020
@eric-czech eric-czech mentioned this issue Oct 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core operations Issues related to domain-specific functionality such as LD pruning, PCA, association testing, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HWE function updates eric-czech/sgkit
2 participants
@hammer @eric-czech