Skip to content

Dask 2.26.0 breaks test_read_vcfzarr #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ravwojdyla opened this issue Sep 12, 2020 · 3 comments
Closed

Dask 2.26.0 breaks test_read_vcfzarr #245

ravwojdyla opened this issue Sep 12, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@ravwojdyla
Copy link
Collaborator

ravwojdyla commented Sep 12, 2020

dask was released yesterday version: 2.26.0 and it breaks our test_read_vcfzarr. That same test works fine on 2.25.0.

Originally posted by @ravwojdyla in https://github.com/pystatgen/sgkit/pull/228#issuecomment-691538352

The issue seems to be that:

    ds["variant_id_mask"] = (
        [DIM_VARIANT],
        variants_id == ".",
    )

returns (['variants'], False) instead of array of bool as the 2nd element.

@ravwojdyla
Copy link
Collaborator Author

ravwojdyla commented Sep 12, 2020

Further:

import dask.array as da

a = da.from_array(["a", "b", ".", "e"])
print(a == ".")

# 2.26.0: False
# 2.25.0: dask.array<eq, shape=(4,), dtype=bool, chunksize=(4,), chunktype=numpy.ndarray>

That's a rather big change.

@ravwojdyla
Copy link
Collaborator Author

ravwojdyla commented Sep 12, 2020

I have reported this as a bug in Dask (and will continue analysis there): dask/dask#6631

@ravwojdyla ravwojdyla added the bug Something isn't working label Sep 12, 2020
@ravwojdyla
Copy link
Collaborator Author

was fixed via #246 closing

@ravwojdyla ravwojdyla self-assigned this Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant