[eslint config] [*] [fix] ensure whitespace entry point is compatible with node 4

Author: 1pete

packages/eslint-config-airbnb-base/.eslintrc

@@ -3,6 +3,8 @@
   "rules": {
     // disable requiring trailing commas because it might be nice to revert to
     // being JSON at some point, and I don't want to make big changes now.
-    "comma-dangle": 0
+    "comma-dangle": 0,
+    // we support node 4
+    "prefer-destructuring": 0,
   },
 }

packages/eslint-config-airbnb-base/package.json

@@ -68,6 +68,7 @@
   },
   "dependencies": {
     "eslint-restricted-globals": "^0.1.1",
+    "object.assign": "^4.1.0",
     "object.entries": "^1.0.4"
   }
 }

packages/eslint-config-airbnb-base/whitespace.js

@@ -1,20 +1,24 @@
 const baseConfig = require('.');
+const assign = require('object.assign');
 const entries = require('object.entries');
-const { CLIEngine } = require('eslint');
+const CLIEngine = require('eslint').CLIEngine;
 
 function onlyErrorOnRules(rulesToError, config) {
-  const errorsOnly = { ...config };
+  const errorsOnly = assign({}, config);
   const cli = new CLIEngine({ baseConfig: config, useEslintrc: false });
   const baseRules = cli.getConfigForFile('./').rules;
 
-  entries(baseRules).forEach(([key, value]) => {
-    if (rulesToError.indexOf(key) === -1) {
-      if (Array.isArray(value)) {
-        errorsOnly.rules[key] = ['warn'].concat(value.slice(1));
-      } else if (typeof value === 'number') {
-        errorsOnly.rules[key] = 1;
+  entries(baseRules).forEach((rule) => {
+    const ruleName = rule[0];
+    const ruleConfig = rule[1];
+
+    if (rulesToError.indexOf(ruleName) === -1) {
+      if (Array.isArray(ruleConfig)) {
+        errorsOnly.rules[ruleName] = ['warn'].concat(ruleConfig.slice(1));
+      } else if (typeof ruleConfig === 'number') {
+        errorsOnly.rules[ruleName] = 1;
       } else {
-        errorsOnly.rules[key] = 'warn';
+        errorsOnly.rules[ruleName] = 'warn';
       }
     }
   });

packages/eslint-config-airbnb/.eslintrc

@@ -3,6 +3,8 @@
   "rules": {
     // disable requiring trailing commas because it might be nice to revert to
     // being JSON at some point, and I don't want to make big changes now.
-    "comma-dangle": 0
-  }
+    "comma-dangle": 0,
+    // we support node 4
+    "prefer-destructuring": 0,
+  },
 }

packages/eslint-config-airbnb/package.json

@@ -50,6 +50,7 @@
   "homepage": "https://github.com/airbnb/javascript",
   "dependencies": {
     "eslint-config-airbnb-base": "^12.1.0",
+    "object.assign": "^4.1.0",
     "object.entries": "^1.0.4"
   },
   "devDependencies": {

packages/eslint-config-airbnb/whitespace.js

@@ -1,20 +1,24 @@
 const baseConfig = require('.');
+const assign = require('object.assign');
 const entries = require('object.entries');
-const { CLIEngine } = require('eslint');
+const CLIEngine = require('eslint').CLIEngine;
 
 function onlyErrorOnRules(rulesToError, config) {
-  const errorsOnly = { ...config };
+  const errorsOnly = assign({}, config);
   const cli = new CLIEngine({ baseConfig: config, useEslintrc: false });
   const baseRules = cli.getConfigForFile('./').rules;
 
-  entries(baseRules).forEach(([key, value]) => {
-    if (rulesToError.indexOf(key) === -1) {
-      if (Array.isArray(value)) {
-        errorsOnly.rules[key] = ['warn'].concat(value.slice(1));
-      } else if (typeof value === 'number') {
-        errorsOnly.rules[key] = 1;
+  entries(baseRules).forEach((rule) => {
+    const ruleName = rule[0];
+    const ruleConfig = rule[1];
+
+    if (rulesToError.indexOf(ruleName) === -1) {
+      if (Array.isArray(ruleConfig)) {
+        errorsOnly.rules[ruleName] = ['warn'].concat(ruleConfig.slice(1));
+      } else if (typeof ruleConfig === 'number') {
+        errorsOnly.rules[ruleName] = 1;
       } else {
-        errorsOnly.rules[key] = 'warn';
+        errorsOnly.rules[ruleName] = 'warn';
       }
     }
   });