glusterd: checked_return coverity fix

Kartik_Burmee · Atin Mukherjee · commit 27e5fbf6eeeb · 2017-11-14T04:51:51.000Z
issue: Calling "recursive_rmdir" without checking return value

fix: typecasted return value of function 'recursive_rmdir' to void

Change-Id: Ie95c2a2c503bb247afa69823d0043c3af5e036e8
BUG: 789278
Signed-off-by: Kartik_Burmee &lt;kburmee@redhat.com&gt;
diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c
@@ -1552,7 +1552,7 @@ glusterd_validate_and_create_brickpath (glusterd_brickinfo_t *brickinfo,
 
 out:
         if (ret && is_created) {
-                recursive_rmdir (brickinfo->path);
+               (void)recursive_rmdir (brickinfo->path);
         }
         if (ret && !*op_errstr && msg[0] != '\0')
                 *op_errstr = gf_strdup (msg);

Original file line number	Diff line number	Diff line change
`@@ -1552,7 +1552,7 @@ glusterd_validate_and_create_brickpath (glusterd_brickinfo_t *brickinfo,`
`1552`	`1552`
`1553`	`1553`	`out:`
`1554`	`1554`	`if (ret && is_created) {`
`1555`		`- recursive_rmdir (brickinfo->path);`
	`1555`	`+ (void)recursive_rmdir (brickinfo->path);`
`1556`	`1556`	`}`
`1557`	`1557`	`if (ret && !*op_errstr && msg[0] != '\0')`
`1558`	`1558`	`*op_errstr = gf_strdup (msg);`