Skip to content

Commit b6898be

Browse files
committed
Convert test_forms to pytest
1 parent 141d3de commit b6898be

File tree

1 file changed

+19
-17
lines changed

1 file changed

+19
-17
lines changed

lists/tests/test_forms.py

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,49 +1,51 @@
1-
from django.test import TestCase
1+
import pytest
22
from lists.forms import ItemForm, EMPTY_ITEM_ERROR, DUPLICATE_ITEM_ERROR, ExistingListItemForm
33
from lists.models import Item, List
44

5+
pytestmark = pytest.mark.django_db
56

6-
class ItemFormTest(TestCase):
7+
8+
class TestItemForm:
79
def test_form_renders_item_text_input(self):
810
form = ItemForm()
9-
self.assertIn('placeholder="Enter a to-do item"', form.as_p())
10-
self.assertIn('class="form-control input-lg"', form.as_p())
11+
assert 'placeholder="Enter a to-do item"' in form.as_p()
12+
assert 'class="form-control input-lg"' in form.as_p()
1113

1214
def test_form_validation_for_blank_items(self):
1315
form = ItemForm(data={'text': ''})
14-
self.assertFalse(form.is_valid())
15-
self.assertEqual(form.errors['text'], [EMPTY_ITEM_ERROR])
16+
assert not form.is_valid()
17+
assert form.errors['text'] == [EMPTY_ITEM_ERROR]
1618

1719
def test_form_save_handles_saving_to_a_list(self):
1820
list_ = List.objects.create()
1921
form = ItemForm(data={'text': 'do me'})
2022
new_item = form.save(for_list=list_)
21-
self.assertEqual(new_item, Item.objects.first())
22-
self.assertEqual(new_item.text, 'do me')
23-
self.assertEqual(new_item.list, list_)
23+
assert new_item == Item.objects.first()
24+
assert new_item.text == 'do me'
25+
assert new_item.list == list_
2426

2527

26-
class ExistingListItemFormTest(TestCase):
28+
class TestExistingListItemForm:
2729
def test_form_renders_item_text_input(self):
2830
list_ = List.objects.create()
2931
form = ExistingListItemForm(for_list=list_)
30-
self.assertIn('placeholder="Enter a to-do item"', form.as_p())
32+
assert 'placeholder="Enter a to-do item"' in form.as_p()
3133

3234
def test_form_validation_for_blank_items(self):
3335
list_ = List.objects.create()
3436
form = ExistingListItemForm(for_list=list_, data={'text': ''})
35-
self.assertFalse(form.is_valid())
36-
self.assertEqual(form.errors['text'], [EMPTY_ITEM_ERROR])
37+
assert not form.is_valid()
38+
assert form.errors['text'] == [EMPTY_ITEM_ERROR]
3739

3840
def test_form_validation_for_duplicate_items(self):
3941
list_ = List.objects.create()
4042
Item.objects.create(list=list_, text='no twins!')
4143
form = ExistingListItemForm(for_list=list_, data={'text': 'no twins!'})
42-
self.assertFalse(form.is_valid())
43-
self.assertEqual(form.errors['text'], [DUPLICATE_ITEM_ERROR])
44+
assert not form.is_valid()
45+
assert form.errors['text'] == [DUPLICATE_ITEM_ERROR]
4446

45-
def test_firm_save(self):
47+
def test_form_save(self):
4648
list_ = List.objects.create()
4749
form = ExistingListItemForm(for_list=list_, data={'text': 'hi'})
4850
new_item = form.save()
49-
self.assertEqual(new_item, Item.objects.all()[0])
51+
assert new_item == Item.objects.all()[0]

0 commit comments

Comments
 (0)